[squeak-dev] The Trunk: Tests-cmm.258.mcz

Frank Shearar frank.shearar at gmail.com
Fri Oct 25 13:19:33 UTC 2013


#testMaximumSubmissionCountDefaultsToTen needs to be renamed to
#testMaximumSubmissionCountDefaultsToThirty.

I do favour returning values, regardless of whether anything
particularly uses it. The image is largely a library, so will often
have things that it itself doesn't use.

frank

On 25 October 2013 03:44, Chris Muller <asqueaker at gmail.com> wrote:
> Hi guys.  Levente, thanks for the reminder about running the tests.  I
> do run them sometimes, but not as part of commit, especially if some
> commit has affected my IDE negatively; I'm not committing to going the
> full mile in that situation as much as simply keeping the tools
> working so I can work.
>
> I think it would be great if we could get CI sending e-mails; with
> some good filtering rules and perhaps also to a new, separate list, so
> that trunk slammers can be appropriately spanked.
>
> This may be another reason to consider we as a community might want
> the ability to send mail; the other being that our reliance on box2
> costs money.
>
> Frank, please pardon if I've been heavy-handed by saying
> #recordSelector:forClass:inEnvironment: does not need to return a
> value without consulting with you first.  I sometimes actually like to
> leave tests failing as a means of stirring discussion, (and CI emails
> could get the ball rolling).  I wanted to respond responsibly to
> Levente too, though.
>
> There is still one test failing but I'm not sure why.  If you know we
> can put RecentMessages to bed?
>
> On Thu, Oct 24, 2013 at 8:32 PM,  <commits at source.squeak.org> wrote:
>> Chris Muller uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-cmm.258.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-cmm.258
>> Author: cmm
>> Time: 24 October 2013, 8:32:17.751 pm
>> UUID: e68974a5-6e3b-451b-be6f-dc8bb41e8577
>> Ancestors: Tests-cmm.257
>>
>> - RecentMessagesTest updated for recent updates.
>> - Support the notion that deletion of a message is worth keeping in RecentMessages.  In the future I'd like to see the ability to browse versions on removed methods so they can be restored right from there.
>> - #recordSelector:forClass:inEnvironment: is basically a private method.  No senders of it ever consume its return value.  If there is no requirement for it to return anything, it shouldn't.
>>
>> =============== Diff against Tests-cmm.257 ===============
>>
>> Item was changed:
>>   ----- Method: RecentMessagesTest>>testMaximumSubmissionCountDefaultsToTen (in category 'testing') -----
>>   testMaximumSubmissionCountDefaultsToTen
>> +       self assert: 30 equals: rm maximumSubmissionCount.!
>> -       self assert: 10 equals: rm maximumSubmissionCount.!
>>
>> Item was changed:
>>   ----- Method: RecentMessagesTest>>testMethodReferencesReturnsAllSubmissions (in category 'testing') -----
>>   testMethodReferencesReturnsAllSubmissions
>>         | expected |
>>         expected := {
>> +               MethodReference class: Utilities selector: #bar environment: env.
>> +               MethodReference class: Utilities selector: #foo environment: env }.
>> -               MethodReference class: Utilities selector: #foo environment: env.
>> -               MethodReference class: Utilities selector: #bar environment: env}.
>>         rm recordSelector: #foo forClass: Utilities inEnvironment: env.
>>         rm recordSelector: #bar forClass: Utilities inEnvironment: env.
>> +       self assert: expected equals: rm methodReferences!
>> -       self assert: expected equals: rm methodReferences.!
>>
>> Item was removed:
>> - ----- Method: RecentMessagesTest>>testMostRecentReturnsLastExtantReference (in category 'testing') -----
>> - testMostRecentReturnsLastExtantReference
>> -       | victim |
>> -       victim := self createClass: #Victim.
>> -       victim compile: 'foo ^ 1'.
>> -       victim compile: 'bar ^ 1'.
>> -       rm recordSelector: #foo forClass: victim inEnvironment: env.
>> -       rm recordSelector: #bar forClass: victim inEnvironment: env.
>> -       victim removeSelector: #bar.
>> -       self assert: #foo equals: rm mostRecent selector.!
>>
>> Item was added:
>> + ----- Method: RecentMessagesTest>>testMostRecentReturnsRemovedReference (in category 'testing') -----
>> + testMostRecentReturnsRemovedReference
>> +       | victim |
>> +       victim := self createClass: #Victim.
>> +       victim compile: 'foo ^ 1'.
>> +       victim compile: 'bar ^ 1'.
>> +       rm recordSelector: #foo forClass: victim inEnvironment: env.
>> +       rm recordSelector: #bar forClass: victim inEnvironment: env.
>> +       victim removeSelector: #bar.
>> +       self assert: #bar equals: rm mostRecent selector.!
>>
>> Item was removed:
>> - ----- Method: RecentMessagesTest>>testRecordSelectorForClassInEnvironmentAlwaysReturnsMethodReference (in category 'testing') -----
>> - testRecordSelectorForClassInEnvironmentAlwaysReturnsMethodReference
>> -       | r |
>> -       WantsChangeSetLogging no.
>> -       r := rm recordSelector: #foo forClass: WantsChangeSetLogging inEnvironment: Smalltalk globals.
>> -       self assert: MethodReference equals: r class description: 'Even when not logging, always return a MethodReference'.!
>>
>> Item was removed:
>> - ----- Method: RecentMessagesTest>>testRecordSelectorForClassInEnvironmentReturnsMethodReference (in category 'testing') -----
>> - testRecordSelectorForClassInEnvironmentReturnsMethodReference
>> -       | r sel class env |
>> -       sel := #foo.
>> -       class := self class.
>> -       env := self class environment.
>> -       r := rm recordSelector: sel forClass: class inEnvironment: env.
>> -       self assert: sel equals: r selector.
>> -       self assert: class equals: r actualClass.
>> -       self assert: env equals: r environment.
>> -
>> -       self assert: r equals: (rm recordSelector: sel forClass: class inEnvironment: env).!
>>
>>
>


More information about the Squeak-dev mailing list