It's fine that each UIManager has its own kind of ToolBuilder, but why 
reuse a single instance over and over?

You have now:

UIManager>>toolBuilder
     ^toolBuilder

MorphicUIManager>>initialize
     toolBuilder := MorphicToolBuilder new

MVCUIManager>>initialize
     toolBuilder := MVCToolBuilder new

so, why that rather than:

MorphicUIManager>>toolBuilder
     ^ MorphicToolBuilder new

MVCUIManager>>toolBuilder
     ^MVCToolBuilder new

?

Cheers,
Bob

On 9/11/13 9:33 AM, David T. Lewis wrote:
> Good question. It was probably a matter of design style. Every Project has
> a UIManager, and that UIManager has its own ToolBuilder instance. That has
> a nice feel to it, and it makes the roles of these things seem more clear.
> It also avoids the need to figure out what kind of ToolBuilder to create
> each time time you use one (normally a trivial concern but possibly more
> complicated when entering one kind of project from another).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130911/8d3c7347/attachment.htm