[squeak-dev] The Trunk: Monticello-bf.562.mcz

Chris Muller asqueaker at gmail.com
Thu Sep 12 01:17:31 UTC 2013


Great!  Good idea, the before and after comparison.  Thanks.

On Wed, Sep 11, 2013 at 11:01 AM, Bert Freudenberg <bert at freudenbergs.de> wrote:
> Not the preloader itself, because it indeed makes the packages dirty. Only after the actual load step happened are the package clean again.
>
> Previously I had tried to implement an "optimal" version that would only check those packages that needed it, but found it complicated the design too much.
>
> Now I thought of a simpler approach, which simply re-checks the packages that were clean before but are dirty after updating. That one I committed.
>
> Also I added the menu item you suggested. It's a good idea to use that in your working image once in a while. The "modified" flag does not always reflect reality, and this resets it. When you do so, you'll notice a lot of unnecessary "updating trunk" progress reports, not sure where these come from.
>
> - Bert -
>
> On 2013-09-11, at 02:56, Chris Muller <asqueaker at gmail.com> wrote:
>
>> Bert could your new MCReorganizationPreloader detect when it did its
>> "move" magic and automatically invoke this utility on the affected
>> packages?
>>
>> Or, at least a menu item.  If false-dirty packages are going to be the
>> norm going forward, we need something easy and accessible.
>>
>> On Tue, Aug 20, 2013 at 2:22 PM, Bert Freudenberg <bert at freudenbergs.de> wrote:
>>> On 2013-08-20, at 12:02, commits at source.squeak.org wrote:
>>>
>>>> Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
>>>> http://source.squeak.org/trunk/Monticello-bf.562.mcz
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: Monticello-bf.562
>>>> Author: bf
>>>> Time: 20 August 2013, 2:02:41.71 pm
>>>> UUID: beda0a3b-0217-4842-a1d0-10dd5f7277d1
>>>> Ancestors: Monticello-cmm.561
>>>>
>>>> Add a utility method to check all packages for modifications, setting or resetting the 'modified' flag by comparing the image to the stored version.
>>>> MCWorkingCopy checkModified: true
>>>
>>>
>>> A couple of packages become dirty after updating even though they should not be. This is because of the recent change that allows to move stuff freely between packages.
>>>
>>> This new utility method can be used to remove the 'modified' flag from these clean-but-marked-dirty packages (MCWorkingCopy checkModified: false). Perhaps this should even be done automatically after updating, but because it is not necessary all the time I did not add that. A thorough check might be a good idea to add as an image building step.
>>>
>>> - Bert -
>>>
>>>
>>>
>>
>
>


More information about the Squeak-dev mailing list