[squeak-dev] Re: The Trunk: Morphic-nice.683.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Tue Sep 24 19:33:01 UTC 2013


Marcel, though I note that a self changed is already performed from the
listMorph via
rowAboutToBecomeSelected: -> preSelectedRow:
So it was probably not sufficient?


2013/9/24 Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>

> Though, I don't see why this would be necessary, just calling changed
> seems OK.
>
>
> 2013/9/24 Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>
>> Or maybe invalidate instead of redraw...
>>
>>
>> 2013/9/24 Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
>>
>>> Hi Marcel,
>>> that looks better to my eyes indeed.
>>> IMHO, Morph>>changed should be renamed redraw, changed should just call
>>> redraw, and changeModelSelection: too.
>>> Should I submit that?
>>>
>>>
>>> 2013/9/24 Marcel Taeumel <marcel.taeumel at student.hpi.uni-potsdam.de>
>>>
>>>> Hi Nicolas,
>>>>
>>>> wouldn't be "self changed" enough to trigger a redraw of the
>>>> PluggableListMorph?
>>>>
>>>> This fix is correct in the sense that #doOneCycle starts processing
>>>> events'n'stuff again, which should clearly not be intended here.
>>>> However,
>>>> #displayWorldSafely forces an immediate redraw. That's why I think that
>>>> it
>>>> could be sufficient to just call #changed or "fullBounds ifNil:[self
>>>> invalidRect: self outerBounds] ifNotNil:[self invalidRect: fullBounds]"
>>>> to
>>>> avoid conflicts with other change-update stuff in the list morph. :)
>>>>
>>>> Good luck for localizing the missing version! :)
>>>>
>>>> Best,
>>>> Marcel
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context:
>>>> http://forum.world.st/The-Trunk-Morphic-nice-683-mcz-tp4709903p4710055.html
>>>> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130924/1ab64f0b/attachment.htm


More information about the Squeak-dev mailing list