[squeak-dev] MutliByteFileStream - failing test fixed

Chris Cunningham cunningham.cb at gmail.com
Tue Aug 26 02:35:58 UTC 2014


Hi.

I would move to include
MultilingualTests-cbc.19.mcz
<http://source.squeak.org/@DkMJpXbIY68oFww2/AiqHJsnF?31> (which makes the
failing test omre informative)
Multilingual-cbc.201.mcz
<http://source.squeak.org/@DkMJpXbIY68oFww2/AiqHJsnF?25> (which fixes the
source so the test doesn't fail)

This is rather a brute-force approach to fixing the test, although if you
want the legacy behaviour (ignoring line ending), either don't set a line
ending converter, or pass wantsLineEndConversion: false to the stream; in
either of these cases, the new logic would be bypassed (correctly) and
there should be no peformance hit at all.  There could be otherwise; if
anyone notices one, let me know - i have an idea how to deal with it, but
would rather not until someone NEEDS it.

-cbc

(ps - could someone with Developer/Admin access please delete
Multilingual-cbc.200.mcz
<http://source.squeak.org/@DkMJpXbIY68oFww2/AiqHJsnF?28> from the inbox?
 It is wrong.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140825/077acaee/attachment.htm


More information about the Squeak-dev mailing list