[squeak-dev] The Inbox: Collections-ul.565.mcz

Chris Muller asqueaker at gmail.com
Mon Feb 3 21:49:54 UTC 2014


Any senders of shouldBePrintedAsLiteralVisiting:?

The other fix for isLiteral was crucial, is this fix crucial to the release too?

Thanks.

On Mon, Feb 3, 2014 at 11:38 AM,  <commits at source.squeak.org> wrote:
> A new version of Collections was added to project The Inbox:
> http://source.squeak.org/inbox/Collections-ul.565.mcz
>
> ==================== Summary ====================
>
> Name: Collections-ul.565
> Author: ul
> Time: 3 February 2014, 6:28:21.892 pm
> UUID: b59d3510-2193-4790-b372-84aa2ff111fa
> Ancestors: Collections-ul.564
>
> Let the following return true:
>
> | a |
> a := #(1).
> { a. a} shouldBePrintedAsLiteral.
>
> =============== Diff against Collections-ul.564 ===============
>
> Item was changed:
>   ----- Method: Array>>shouldBePrintedAsLiteralVisiting: (in category 'testing') -----
>   shouldBePrintedAsLiteralVisiting: aSet
> +
> +       | result |
>         self class == Array ifFalse:
>                 [^false].
>         (aSet includes: self) ifTrue:
>                 [^false].
>         aSet add: self.
> +       result := self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet].
> +       aSet remove: self.
> +       ^result!
> -       ^self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]!
>
>


More information about the Squeak-dev mailing list