[squeak-dev] The Trunk: Tests-cmm.290.mcz
Chris Muller
asqueaker at gmail.com
Tue Feb 18 22:32:52 UTC 2014
The upper set of +'s is a non-change -- just a side-effect of my
having used code-format because I was too lazy to manually format this
time. Normally I only reformat when I drastically change a method,
sometimes I get lazy though.
Bottom change simply factor "aNotification resume:" out of the conditional.
PS -- Code for our SqueakSource is actually in the same instance in
case you wish to browse it:
MCHttpRepository
location: 'http://source.squeak.org/ss'
user: ''
password: ''
On Tue, Feb 18, 2014 at 4:21 PM, Frank Shearar <frank.shearar at gmail.com> wrote:
> On 17 February 2014 22:35, <commits at source.squeak.org> wrote:
>> Chris Muller uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-cmm.290.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-cmm.290
>> Author: cmm
>> Time: 17 February 2014, 4:35:24.565 pm
>> UUID: f3fccfae-6baf-4093-ba62-e15ef110a687
>> Ancestors: Tests-cwp.289
>>
>> Minor factoring.
>>
>> =============== Diff against Tests-cwp.289 ===============
>>
>> Item was changed:
>> ----- Method: BlockLocalTemporariesRemovalTest>>assert:isChangedDuringParsingTo:withRemovalOfTemporariesNamed: (in category 'test helper') -----
>> + assert: someCode isChangedDuringParsingTo: someOtherCode withRemovalOfTemporariesNamed: someTempNames
>> - assert: someCode isChangedDuringParsingTo: someOtherCode withRemovalOfTemporariesNamed: someTempNames
>> -
>> | failBlock |
>> self sourceCode: someCode.
>> + failBlock := [ self fail ].
>> + [ self class
>> + compile: self sourceCode
>> + notifying: self
>> + trailer: self class defaultMethodTrailer
>> + ifFail: failBlock ]
>> - failBlock := [self fail].
>> - [self class
>> - compile: self sourceCode
>> - notifying: self
>> - trailer: self class defaultMethodTrailer
>> - ifFail: failBlock]
>> on: UnusedVariable
>> + do:
>> + [ : aNotification | aNotification openMenuIn:
>> + [ : options : emptyCollection : someText | aNotification resume:
>> + (someTempNames anySatisfy:
>> + [ : tempName | someText beginsWith: tempName ]) ] ].
>> - do: [:aNotification | aNotification
>> - openMenuIn: [:options :emptyCollection :someText |
>> - (someTempNames anySatisfy: [:tempName | someText startsWith: tempName])
>> - ifTrue: [aNotification resume: true]
>> - ifFalse: [aNotification resume: false]]].
>> self assert: self sourceCode = someOtherCode!
>
> Seriously, we need a better differ. If we pretty-printed the before &
> after I'd at least stand a chance of not going blind trying to find
> the change here. How difficult a change is it to SS? Surely a
> one-liner, to someone who knows the codebase (i.e., not me).
>
> frank
>
More information about the Squeak-dev
mailing list
|