[squeak-dev] The Trunk: Tests-fbs.285.mcz

Frank Shearar frank.shearar at gmail.com
Thu Jan 9 13:03:58 UTC 2014


On 9 January 2014 12:32,  <commits at source.squeak.org> wrote:
> Frank Shearar uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-fbs.285.mcz
>
> ==================== Summary ====================
>
> Name: Tests-fbs.285
> Author: fbs
> Time: 9 January 2014, 12:32:14.059 pm
> UUID: 8a2dc139-e417-ff40-8a02-1077909eff36
> Ancestors: Tests-fbs.284
>
> More "more descriptive errors" items: I missed these last time round.
>
> =============== Diff against Tests-fbs.284 ===============
>
> Item was changed:
>   ----- Method: EnvironmentTest>>testUndeclare (in category 'binding tests') -----
>   testUndeclare
>         | one two |
>         one := env undeclare: #Griffle.
>         two := env bindingOf: #Griffle.
> +       self assert: two equals: one description: '#bindingOf: value doesn''t match that returned by #undeclare'.
> -       self assert: one == two description: '#bindingOf: value doesn''t match that returned by #undeclare'.
>         self assert: Global equals: one class description: 'Type of binding'.
>         self assert: nil equals: one value description: 'Value of binding'.!

This test checks, among other things, that the binding of an
undeclared thing is the same object as the object you got back when
you undeclared it.

That's not true at the moment: if you undeclare Griffle, #undeclare:
returns the binding, and #bindingOf: then returns nil.

We could make the test pass by removing the first assert (or better,
replacing the line with " self assert: nil equals: two description:
'#bindingOf:'."), but I thought it worth discussing first, before I
did that.

frank


More information about the Squeak-dev mailing list