On Thu, Jan 9, 2014 at 3:47 AM, Frank Shearar <frank.shearar at gmail.com>wrote:


>
> It does for SUnit what older commits did for MVC and Morphic: moves
> the UI-framework-specific code to that particular UI framework, so
> that the core of ToolBuilder remains UI agnostic.
>
> The problem with shrinking that you refer to is, presumable, that
> SUnitToolBuilderTests superclass == AnObsoleteToolBuilderTests? I'd
> noticed that, and asked on the list how I might fix that. If you can
> suggest an action I can take to remedy the problem, I'm all ears.
>

No, the problem with shrinking is that I want to remove SUnitToolBuilder
without removing TestRunner.

TestRunner provides a GUI for running tests. SUnitToolBuilder provides
infrastructure for testing a GUI. They *sound* similar, but really they're
completely different, and should be in separate packages.

On the other hand, the ToolBuilder packages were already separate from each
other. Admittedly, if you don't have MVC in the image, you probably don't
want ToolBuilder-MVC either, but that's not a reason to tie them together;
it's reasonable to want MVC only and not use ToolBuilder at all. It seems
that these changes have introduced coupling to what was already a nicely
modularized group of packages.

I'm sorry I didn't notice this when you first brought it up—I was busy with
dirty-world stuff in May and not paying much attention to the Internet. I
think the right thing to do is just revert these changes.

Colin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140109/12f43daf/attachment.htm