[squeak-dev] The Trunk: System-cwp.661.mcz

Frank Shearar frank.shearar at gmail.com
Fri Jan 10 08:21:33 UTC 2014


On 9 January 2014 23:57,  <commits at source.squeak.org> wrote:
> Colin Putney uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cwp.661.mcz
>
> ==================== Summary ====================
>
> Name: System-cwp.661
> Author: cwp
> Time: 9 January 2014, 6:56:09.652 pm
> UUID: d6fdfa88-0d1f-45b0-898a-dd1298e6da72
> Ancestors: System-cwp.660
>
> Fix the bug I introduced to SystemNavigation>>allObjectsDo:.
>
> =============== Diff against System-cwp.660 ===============
>
> Item was changed:
>   ----- Method: SystemNavigation>>allObjectsDo: (in category 'query') -----
>   allObjectsDo: aBlock
>         "Evaluate the argument, aBlock, for each object in the system
>         excluding SmallIntegers. With closures, this needs to use an end
>         marker (lastObject) since activation of the block will create new
>         contexts and cause an infinite loop."
>         | object lastObject |
>         object := self someObject.
>         lastObject := Object new.
> +       [lastObject == object or: [0 == object]]
> -       [lastObject == object | object == 0]
>                 whileFalse: [aBlock value: object.
>                         object := object nextObject]!
>
> Item was added:
> + ----- Method: TextSqkProjectLink>>writeScanOn: (in category 'as yet unclassified') -----
> + writeScanOn: strm
> +
> +       strm nextPut: $p; nextPutAll: url; nextPut: $;!

I don't think you meant to commit this chunk. I've seen it crop up a
few times, and have actually figured out why it happens twice... and
forgotten again. The method is supposed to be in System, though.

frank


More information about the Squeak-dev mailing list