It's to fix a serious flaw in the History workflow :) I keep selecting
the top item, wanting to know "how does it differ compared to its
ancestor" and failing. Selecting the _second_ item does _not_ yield
the same information: it yields the _inverse_ change. OK, so I know
you said you know that.

You say "blow up" - what do you mean? Do you see an error?

frank

On 21 January 2014 21:36, Chris Muller <asqueaker at gmail.com> wrote:
> Ok, I see.  It's so you can select the working copy and still get a
> context menu.  But everything on that menu is available from the first
> ancestor (2nd item in the list).  I know, doing that presents the
> changes from the other viewpoint, but I'd rather not have the blow
> up..
>
> On Tue, Jan 21, 2014 at 3:23 PM, Chris Muller <asqueaker at gmail.com> wrote:
>> Could you help me understand what this change is about?  Without
>> trying to understand the code, I see no difference in the behavior,
>> except that now it blows up when yellow-clicking when nothing is
>> selected.
>>
>> Thanks.
>>
>> On Sat, Jan 18, 2014 at 10:58 AM,  <commits at source.squeak.org> wrote:
>>> Frank Shearar uploaded a new version of Monticello to project The Trunk:
>>> http://source.squeak.org/trunk/Monticello-fbs.581.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Monticello-fbs.581
>>> Author: fbs
>>> Time: 18 January 2014, 4:58:44.499 pm
>>> UUID: bd327588-05f4-cf4c-87cd-1f5039cb4b04
>>> Ancestors: Monticello-cmm.580
>>>
>>> When browsing the history of a version, you may now select the current version and find out its changes relative to its ancestor.
>>>
>>> =============== Diff against Monticello-cmm.580 ===============
>>>
>>> Item was changed:
>>>   ----- Method: MCVersionHistoryBrowser>>getMenu: (in category 'morphic ui') -----
>>>   getMenu: aMenu
>>> +       | menuSpecs |
>>> +       menuSpecs := (self selectedInfo ancestors collect: [:parent |
>>> -       self selection < 2 ifTrue: [^ aMenu].
>>> -       self fillMenu: aMenu fromSpecs:
>>> -               {{'view changes to ', ancestry name . #viewChanges}},
>>> -               (self selectedInfo ancestors collect: [:parent |
>>>                         {'view changes from ', parent name . #viewChanges: . parent}]),
>>>                 #(('spawn history' spawnHistory)
>>>                 ('search history' searchHistory)).
>>> +       self selection > 1 ifTrue: [
>>> +               menuSpecs := {{'view changes to ', ancestry name . #viewChanges}}, menuSpecs].
>>> +
>>> +       self fillMenu: aMenu fromSpecs: menuSpecs.
>>>         ^ aMenu!
>>>
>>>
>