[squeak-dev] The Trunk: Kernel-eem.858.mcz

Chris Muller asqueaker at gmail.com
Sun Jul 20 16:18:16 UTC 2014


Clearly, your fix is the most-correct for BlockClosure>>#sourceString.  I'm
only using it in one place and I will look at sending #value to it.

Sorry for the noise..


On Sat, Jul 19, 2014 at 11:09 AM, Chris Muller <asqueaker at gmail.com> wrote:

> Hey, this blows me up.  You've changed the _behavior_ of printSourceOn:,
> not fixed bugs, at least for me.  I actually need the *inner* source of the
> block, _excluding_ the brackets.  Sure, I could use String manipulation to
> trim those but is this a change based on "principle", or something which
> you actually have real-world need including the brackets?
>
>
> On Fri, Jul 18, 2014 at 11:40 AM, <commits at source.squeak.org> wrote:
>
>> Eliot Miranda uploaded a new version of Kernel to project The Trunk:
>> http://source.squeak.org/trunk/Kernel-eem.858.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Kernel-eem.858
>> Author: eem
>> Time: 18 July 2014, 9:40:15.375 am
>> UUID: 43c040b0-53f8-43e0-a8c9-42fbaba86a27
>> Ancestors: Kernel-eem.857
>>
>> Fix a couple of bugs in BlockClosure>>printSourceOn:
>>
>> =============== Diff against Kernel-eem.857 ===============
>>
>> Item was changed:
>>   ----- Method: BlockClosure>>printSourceOn: (in category 'printing')
>> -----
>>   printSourceOn: aStream
>>         self decompile
>> +               ifNil: [ aStream nextPutAll: '--source missing--' ]
>> +               ifNotNil: [ : blockNode | blockNode printOn: aStream
>> indent: 0 ]!
>> -               ifNil: [ aStream nextPutall: '--source missing--' ]
>> -               ifNotNil:
>> -                       [ : parseNode | parseNode statements anyOne
>> -                               printOn: aStream
>> -                               indent: 0 ]!
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140720/004acab1/attachment.htm


More information about the Squeak-dev mailing list