[squeak-dev] Re: Spur vs Cog: FileDirectory paths

Nicolai Hess nicolaihess at web.de
Sun Sep 14 21:54:43 UTC 2014


2014-09-14 23:18 GMT+02:00 Eliot Miranda <eliot.miranda at gmail.com>:

>
>
> On Sep 14, 2014, at 9:46 AM, Bert Freudenberg <bert at freudenbergs.de>
> wrote:
>
> On 14.09.2014, at 17:44, Ben Coman <btc at openInWorld.com> wrote:
>
>  Eliot Miranda wrote:
>
>
>
> On Thu, Sep 11, 2014 at 1:01 PM, Frank Shearar <frank.shearar at gmail.com>
> wrote:
>
>> Hi Eliot,
>>
>> OK, the good news is it's not a Spur bug. I mistakenly checked spur +
>> trunk46-image.image against cog + trunk-fully-updated. Not the same
>> thing.
>>
>> The bad news is that
>>
>> FileDirectory default on:
>> 'C:/Users/frsheara/squeak-ci/target/cogspur.r3072/cogspurwin/' gives
>>
>> 'C:\Users\frsheara\squeak-ci\target\C:/Users/frsheara/squeak-ci/target/cogspur.r3072/cogspurwin/'.
>>
>> But I'm OK with being told "#on: should only take a relative path,
>> indicating a subdirectory of FileDirectory default; it's not a bug".
>>
>
>  Bah, I'd fix it.  I fixed it for unix.  It's only a little bit of
> checking to see if the path starts with letter colon.
>
>
> I didn't see all of this thread, but I presume you are distinguishing
> between relative and absolute pathnames.  As well as the initial
> letter-colon, an absolute pathname also requires position 3 to contain a
> slash.
> See the "Paths" section only of...
> http://msdn.microsoft.com/en-us/library/aa365247.aspx#fully_qualified_vs._relative_paths
>
> cheers -ben
>
>
> I have no idea why you guys are discussing this. It's all coded up in
> DosFileDirectory>>fullPathFor:, and working fine.
>
> The only issue seems to be that Eliot made an unwarranted change to
> FileDirectory>>on: in the Spur image. reverting it should solve the problem.
>
>
> In the Spur image?  Can you point me to it?  I thought I'd left Files
> unchanged in Spur.  I thought I changed things in trunk.  And if I broke
> things I'll fix them.
>
>
>
FileDirectory
on: path
    "Return another instance"

    ^ self class on: ((path at: 1 ifAbsent: nil) = self pathNameDelimiter
                        ifTrue: [path]
                        ifFalse: [pathName asString, (String with: self
pathNameDelimiter), path])


 (eem 4/21/2014 14:57 · path access · 71 implementors · only in change set
Files-eem.135  · )

Image
-----
c:\Users\nicolai\Downloads\spur\trunk46-spur.image
Squeak4.5
latest update: #13924
Current Change Set: Unnamed1
Image format 6521 (32 bit)



> - Bert -
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140914/c022837a/attachment.htm


More information about the Squeak-dev mailing list