2014-09-16 20:08 GMT+02:00 Tobias Pape <Das.Linux at gmx.de>:

> Hi,
>
>
> On 16.09.2014, at 19:19, Nicolas Cellier <
> nicolas.cellier.aka.nice at gmail.com> wrote:
>
> > Nice catch indeed.
>
> Wasn't me, but some of our students.
> They also found the dormant mantis entry…
> I have no Idea why it works, to be honest.
>
> > But, ouch!
> >     (self left @ self top) ~= self topLeft...
> > Without looking at the code, it sounds like heresy!
> > Wouldn't the real fix be to name a cat a cat? (a corner a corner in this
> case).
>
> Yes, it would.
>
> >
> > After a brief look at the code, of course things are not so simple.
> > I'm not sure I completely understand the contracts, but inside the owner
> rectangular area, there are only some portions available for displaying
> text, and top answers the topMostAvailableDisplayArea...
> > This fake insulate some users of top from the knowledge of this
> availableAreaForDisplay feature which sounds like a good thing...
> > But in the same time, it fakes the innocent users of topLeft expecting
> top+left=topLeft.
> > No matter the di initials (sorry to scratch an icon), but IMO it's a
> well too sophisticated hack, and such hacks inevitably leads to such bugs.
> >
> > As why we do not apply such ingeniosity to left, it's above my current
> understanding.
> >
> >
>
> I  found that that container (as per some Class comment) can be a
> TextContainer _or_ a Rectangle.
> And they apparently do different things on topLeft vs top @ left.
> I have no idea :)
>
> I had to convince myself again (I got the report 2month ago) that it
> indeed is the fix necessary…
>
> Lets call a cat a cat.
> Right after we fixed all the other stuff
>
> >
> >
> > 2014-09-16 17:29 GMT+02:00 Frank Shearar <frank.shearar at gmail.com>:
> > On 16 September 2014 16:16,  <commits at source.squeak.org> wrote:
> > > Tobias Pape uploaded a new version of Graphics to project The Trunk:
> > > http://source.squeak.org/trunk/Graphics-topa.301.mcz
> > >
> > > ==================== Summary ====================
> > >
> > > Name: Graphics-topa.301
> > > Author: topa
> > > Time: 16 September 2014, 5:16:44.215 pm
> > > UUID: a66aac86-031b-4db4-97ce-e33376745f9e
> > > Ancestors: Graphics-mt.300
> > >
> > > Fix Mantis 5711
> > >         http://bugs.squeak.org/view.php?id=5711
> > > after 7 years...
> > >
> > > =============== Diff against Graphics-mt.300 ===============
> >
> > Don't forget to tell Mantis that :)
>
> Can Frank or Nicolas do that please? I cannot.
>
>
>
> Best
>         -Tobias
>
>
Done,
But who could grant you more priviledges?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140917/c8377164/attachment.htm