[squeak-dev] Next version of Date, DateAndTime, and Duration API updates

Bert Freudenberg bert at freudenbergs.de
Fri Sep 19 08:42:22 UTC 2014


On 19.09.2014, at 08:29, Chris Cunningham <cunningham.cb at gmail.com> wrote:

> Now in the InBox:
>    KernelTests-cbc.278.mcz
>    Kernel-cbc.871.mcz
> The tests add in test for expected Duration addition and subtraction from each other, including the new GenericMonth and GenericYear, and the very new GenericDuration.  It also adds a few more tests for LeapYear tests with adding years to them.
> 
> The test are still based on what it currently does, with the exceptions listed previously (I haven't really changed any to expect failures, as has been suggested - that will come shortly.  For now, I want to try to cause little to no changes o expected behavior first - just new behavior for now).
> 
> Kernel adds the GenericDuration, and handles adding and subtracting GenericMonth, GenericYear, and GenericDurations togeher in a rational way.  This involves turning + and - in Durations into a double-dispatch so that it will work.
> 
> There are no comments  yet in these classes - they will be there before the weekend is over at the latest.
> 
> Any comments are more than welcome.

Just eyeballing the code it looked okay.

You still need to implement #hash since you implemented #= (when two objects are equal they must answer the same hash).

- Bert -

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4142 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20140919/93686c8f/smime.bin


More information about the Squeak-dev mailing list