[squeak-dev] Re: The Trunk: ToolBuilder-Morphic-cmm.109.mcz

Marcel Taeumel marcel.taeumel at student.hpi.uni-potsdam.de
Wed Apr 1 16:39:13 UTC 2015


Hey Chris,

yay, we need to strive for more consistency in the tools. This is a step in
the right direction. :-)

Here are some minor remarks:

#setSelectedMorph:
- Calling #selection: from within that is against the rules. This is only
called as a reaction to model change. See #update:.

#filterTree
- Maybe we should not filter the children of the current selection but start
with the siblings?

Best,
Marcel



--
View this message in context: http://forum.world.st/The-Trunk-ToolBuilder-Morphic-cmm-109-mcz-tp4816694p4816713.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.


More information about the Squeak-dev mailing list