Hi Tobias,

On Tue, Apr 7, 2015 at 5:30 AM, Tobias Pape <Das.Linux at gmx.de> wrote:

> Hi
>
>
> On 04.04.2015, at 16:59, Frank Shearar <frank.shearar at gmail.com> wrote:
>
> > On 3 April 2015 at 16:27, Tobias Pape <Das.Linux at gmx.de> wrote:
> >> Hey
> >>
> >> I am watching the CI doing its work as changes and fixes
> >> chime in.
> >>  I noticed that there are still 13 test failing[1] and I'm
> >> not sure how all of them should be fixed :)
> >>  Let's make it green!
> >
> > I am _very very happy_ to see someone other than me harping on about
> > tests! Please carry on!
> >
> > This one ought to be easy to fix: it's a small breakage in the
> > modularity of the image; some methods need to be recategorised as not
> > being System:
> http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testSystem/
> >
> > This one too:
> http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testTools/
> > (Tools shouldn't depend on _ToolBuilder-Morphic_, even though it would
> > be OK to depend on ToolBuilder.)
> >
> > And I love that this one fails -
> >
> http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testMultilingual/
> > - Multilingual no longer depends on TrueType, and our system just got
> > one dependency cleaner.
>
> I did some things :)
>
> But I need help:
> There's a strange thing in the decompiler/compiler:
>
>
> http://build.squeak.org/job/SqueakTrunk/lastCompletedBuild/testReport/Tests.Compiler/DecompilerTests/testDecompilerInClassesBAtoBM/
>
> Somewhere in Behavior>>#toolIconSelector:,
> a sequence of 'push nil. pop' is generated that is decompiled as 'nil.'.
>

Can you mail the symbolic output that shows the bytecode please?  SOmetimes
the COmpiler is changed but the system is not recompiled, and hence
bytecode can be obsolete.  I don't think we should bother to fix the
decompiler for these cases.  But we should remember to do a recompile all
at some stage, either before a release or whenever a change to the compiler
is made that would change generated code.


> This does not match the source and I don't know whether it's a bug in
> the Compiler emitting this or the Decompiler not recognizing the emitted
> pattern.
>

So what happens if you recompile the method?  Is the push nil, pop sequence
still there?


> Best
>         -Tobias
>
>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20150408/0a0b6d46/attachment.htm