[squeak-dev] WeakArray species (was The Trunk: Collections-bf.612.mcz)

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Fri Apr 10 15:21:06 UTC 2015


This sounds like scories left by another TestCase...
So natural questions arising are
- doesn't it depend on the ordering of test cases?
- How are TestCase ordered exactly?


2015-04-10 17:03 GMT+02:00 Bert Freudenberg <bert at freudenbergs.de>:

>
> > On 10.04.2015, at 16:38, Bert Freudenberg <bert at freudenbergs.de> wrote:
> >
> >
> >> On 09.04.2015, at 20:27, Tobias Pape <Das.Linux at gmx.de> wrote:
> >>
> >> Hi,
> >>
> >> On 09.04.2015, at 12:03, Bert Freudenberg <bert at freudenbergs.de> wrote:
> >>
> >>> On 08.04.2015, at 18:03, Chris Muller <asqueaker at gmail.com> wrote:
> >>>>
> >>>> The impetus for the change was so that (WeakArray new = Array new)
> >>>> would return true instead of false.  But we could accomplish that by
> >>>> overriding #= instead of #species, I think..
> >>>>
> >>>> Do you think overriding #species in WeakArray at this point in the
> >>>> release process is too aggressive?
> >>>
> >>> Not sure. The #testNoObsoleteClasses test is still failing, even
> though there were fewer obsolete classes when we fixed
> WeakArray>>copyWith:. Would reverting #species help fix these for good?
> >>
> >> I am unsure. Is there a weak-ref-guru out there?
> >
> > It would help to know what still holds onto the obsolete classes.
> Unfortunately, the test image does not get saved for a post-mortem.
> >
> > Let's see if Collections-bf.614 makes a difference ...
>
> Nope, no difference:
>
>
>
> ====================================================================================
> http://build.squeak.org/job/SqueakTrunk/1250/console
> 2015-04-10T16:54:29.378+01:00: Collections (bf.614)
>
> Failed Tests.Release.ReleaseTest.testNoObsoleteClasses (from Tests)
>
> Failing for the past 620 builds (Since #631 )
> Took 92 ms.
> Error Message
>
> AnObsoleteMCMockClassA, AnObsoleteMCMockASubclass, AnObsoleteMCMockClassB,
> AnObsoleteMCMockClassD, AnObsoleteMCMockClassE, AnObsoleteMCMockClassF,
> AnObsoleteMCMockClassG, AnObsoleteMCMockClassH, AnObsoleteMCMockClassI,
> AnObsoleteClassVarScopeParent, AnObsoleteClassVarScopeChild,
> AnObsoleteClassVarScopeGrandchild, AnObsoleteClassVarScopeParent,
> AnObsoleteClassVarScopeChild, AnObsoleteClassVarScopeGrandchild,
> AnObsoleteClassVarScopeParent, AnObsoleteClassVarScopeChild,
> AnObsoleteClassVarScopeGrandchild, AnObsoleteClassVarScopeParent,
> AnObsoleteClassVarScopeChild, AnObsoleteClassVarScopeGrandchild,
> AnObsoleteClassVarScopeParent, AnObsoleteClassVarScopeChild,
> AnObsoleteClassVarScopeGrandchild, AnObsoleteClassVarScopeParent,
> AnObsoleteClassVarScopeChild, AnObsoleteClassVarScopeGrandchild,
> AnObsoleteClassVarScopeParent, AnObsoleteClassVarScopeChild,
> AnObsoleteClassVarScopeGrandchild, AnObsoleteClassVarScopeParent,
> AnObsoleteClassVarScopeChild, AnObsoleteClassVarScopeGrandchild,
> AnObsoleteClassVarScopeParent, AnObsoleteClassVarScopeChild,
> AnObsoleteClassVarScopeGrandchild, AnObsoleteClassVarScopeParent,
> AnObsoleteClassVarScopeChild and AnObsoleteClassVarScopeGrandchild are
> obsolete
>
> Stacktrace
>
> ReleaseTest(TestCase)>>assert:description:
> ReleaseTest>>testNoObsoleteClasses
> ReleaseTest(TestCase)>>performTest
>
> ====================================================================================
>
>
>
> - Bert -
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20150410/ab6cef10/attachment.htm


More information about the Squeak-dev mailing list