On Mon, 27 Apr 2015, commits at source.squeak.org wrote:

> Chris Muller uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cmm.725.mcz
>
> ==================== Summary ====================
>
> Name: System-cmm.725
> Author: cmm
> Time: 27 April 2015, 3:20:18.66 pm
> UUID: b166e202-b3c3-4232-a17e-cd55a873fa50
> Ancestors: System-mt.724
>
> - Attempting to load preferences is blowing up, fix by restoring the old one-click behavior.
> - Proper fix for browsing allStoresInto: SomeClassVar from: aClassOrMetaclass, so that all stores occurring in either the instance or class side will be revealed even if the browse was initiated from the class-side.
>
> =============== Diff against System-mt.724 ===============
>
> Item was changed:
>  ----- Method: Preferences class>>preferenceAt:ifAbsent: (in category 'preference-object access') -----
>  preferenceAt: aSymbol ifAbsent: aBlock
>  	"Answer the Preference object at the given symbol, or the value of aBlock if not present"
>
> + 	^self accessDictionaryOfPreferencesIn: [ :dictionaryOfPreferences |
> + 		dictionaryOfPreferences at: aSymbol ifAbsent: aBlock ]!
> - 	 self accessDictionaryOfPreferencesIn: [ :dictionaryOfPreferences |
> -                 dictionaryOfPreferences
> -                         at: aSymbol
> -                         ifPresent: [ :preference | ^preference ] ].
> -         ^aBlock value!

The above change restores the old behavior of locking up the image, so it 
should be reverted. An additional comment explaininng why aBlock must 
not be evaluated inside the argument of #accessDictionaryOfPreferencesIn: 
would be helpful.
It would be even better to finally get rid of DictionaryOfPreferences.


Levente