> On 12.02.2015, at 14:28, commits at source.squeak.org wrote:
> 
> Tim Felgentreff uploaded a new version of Balloon to project The Inbox:
> http://source.squeak.org/inbox/Balloon-tfel.26.mcz
> 
> ==================== Summary ====================
> 
> Name: Balloon-tfel.26
> Author: tfel
> Time: 12 February 2015, 3:28:04.366 pm
> UUID: 94ab88a7-1f0f-0048-b15f-1a604dc5601a
> Ancestors: Balloon-tfel.22, Balloon-bf.25
> 
> Instead of failing hard, return default values from Balloon primitive methods, for VMs without plugin (i.e., RSqueakVM)
> 
> =============== Diff against Balloon-bf.25 ===============
> 
> Item was changed:
>  ----- Method: BalloonEngine>>primAddActiveEdgeTableEntryFrom: (in category 'primitives-incremental') -----
>  primAddActiveEdgeTableEntryFrom: edgeEntry
>  	"Add edge entry to the AET."
>  	<primitive: 'primitiveAddActiveEdgeEntry' module: 'B2DPlugin' error: errorCode>
>  	(self canProceedAfter: self primGetFailureReason) ifTrue:[
>  		^self primAddActiveEdgeTableEntryFrom: edgeEntry
>  	].
> + 	^ 0!
> - 	^self primitiveFailed!


I'm not so sure suppressing the error messages is a good idea. Shouldn't we rather change some higher-level code to not use Balloon if the plugin is not available?

- Bert -

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4115 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20150212/aced988b/smime.bin