[squeak-dev] Re: the Warning changes
David T. Lewis
lewis at mail.msen.com
Wed Jul 15 01:28:44 UTC 2015
On Tue, Jul 14, 2015 at 05:58:20PM -0700, Eliot Miranda wrote:
>
> On Tue, Jul 14, 2015 at 5:42 PM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
> >
> > has anyone else noticed that now the Notifier doesn't contain a stack
> > trace, only a copy of the title, the message text of the exception? Isn't
> > this a regression from the recent Warning changes? Can we please have the
> > stack trace back in cases other than Warning? I'm playing with events in
> > the VM simulator which are breaking the UI, and its difficult to debug
> > without a stack trace to show me where I've botched things up.
>
>
> yes, Chris, the change to Debugger>>openNotifierContents:label:, cmm
> 7/2/2015 11:18, borks the stack trace. i.e. this
>
> spec := self buildNotifierWith: builder label: label message: msg.
>
> became
>
> spec := self buildNotifierWith: builder label: label message: (msg ifNil:
> [label]).
>
> which means no stack trace ever. I think it needs to be something like
>
> spec := self buildNotifierWith: builder label: label message: (msg ifNil:
> [(label beginsWith: 'Warning:') ifTrue: [label]]).
>
> Is this serious enough to go for another release candidate? IMO it is, but
> I'd like to canvas opinions.
Yes I have noticed it, and yes I would like to see it fixed.
No, it is not serious enough to require another release candidate. There is
(or will be) a 4.6 update stream available to manage updates like this.
The 4.6 release is almost done. Let's make it so.
Dave
More information about the Squeak-dev
mailing list
|