[squeak-dev] The Trunk: HelpSystem-Core-kfr.75.mcz

commits at source.squeak.org commits at source.squeak.org
Thu Jun 4 07:59:48 UTC 2015

Marcel Taeumel uploaded a new version of HelpSystem-Core to project The Trunk:

==================== Summary ====================

Name: HelpSystem-Core-kfr.75
Author: kfr
Time: 13 May 2015, 1:52:38.849 pm
UUID: 5b487f7f-b174-5343-894a-aff28511d4fa
Ancestors: HelpSystem-Core-mt.74

HelpBrowser>>accept: changed so it works. The changed topic is compiled but the current topic loaded in the HelpBrowser is not updated

=============== Diff against HelpSystem-Core-mt.74 ===============

Item was changed:
  ----- Method: HelpBrowser>>accept: (in category 'actions') -----
  accept: text
  	"Accept edited text. Compile it into a HelpTopic"
+ 	| code topicClass topicMethod updatedTopic |
+ 	"true ifTrue:[^self inform: 'Not implemented yet.', String cr, 'Make new help pages in the browser for the time being']."
+ 	(self find: (self currentTopic contents copyFrom: 1 to: 20)) asArray 
+ 		ifNotEmpty: [:refs |
- 	| code topicClass topicMethod |
- 	true ifTrue:[^self inform: 'Not implemented yet.', String cr, 'Make new help pages in the browser for the time being'].
- 	(self find: self topic contents) asArray ifNotEmpty: [:refs |
  		topicClass := refs first actualClass theNonMetaClass. 
  		topicMethod := refs first selector].
  	code := String streamContents:[:s|
  		s nextPutAll: topicMethod.
  		s crtab; nextPutAll: '"This method was automatically generated. Edit it using:"'.
  		s crtab; nextPutAll: '"', self name,' edit: ', topicMethod storeString,'"'.
  		s crtab; nextPutAll: '^HelpTopic'.
  		s crtab: 2; nextPutAll: 'title: ', currentTopic title storeString.
  		s crtab: 2; nextPutAll: 'contents: '.
  		s cr; nextPutAll: (String streamContents:[:c| c nextChunkPutWithStyle: text]) storeString.
  		s nextPutAll:' readStream nextChunkText'.
+ 	updatedTopic := topicClass class
- 	topicClass class
  		compile: code
  		classified: ((topicClass class organization categoryOfElement: topicMethod) ifNil:['pages']).
  	self flag: #fixme. "mt: Update will not work because the topic builder eagerly cached all the contents and lost track of its origins. We need to get rid of the topic builders and create topic contents lazily resp. live."
+ 	self currentTopic: updatedTopic.
  	self changed: #toplevelTopics..
  	self changed: #currentTopic.
  	self changed: #topicContents.

More information about the Squeak-dev mailing list