Right, there is no need for a UIManager to hold an instance of a tool
builder. In particular, the following code is sufficient to build a tool
with the morphic tool builder:

ObjectExplorer new buildWith: MorphicToolBuilder new.

The builder is shared along the control flow of #buildWith: in any standard
tool. There is no real speedup achieved by saving the instance of a builder
for later use. I am not aware of any code that relies on it anyway.

We should do this:

- remove #toolBuilder and instance variable from UIManager
- change ToolBuilder >> #default to always create a new instance
- remove #default: from ToolBuilder

Then GC might work. :)

Best,
Marcel



--
View this message in context: http://forum.world.st/MorphicToolBuilder-holds-onto-stuff-tp4813024p4813091.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.