This sounds like the sort of change that might benefit from a couple of
days in the inbox.

Dave

On Sat, Nov 21, 2015 at 11:49:54AM -0600, Chris Muller wrote:
> Hi Marcel, I hope you can find another solution to the Undo.  The
> change that was made to autoEnclose introduced several bugs, whilst
> nullifying one use case and overloading another.
> 
> User-expectations about selection-replacement were violated -- we just
> talked about this for the Tab key.  When the user types a regular
> character into the Editor, they expect that character to be typed.  If
> the user wishes to modify that expected behavior, they may use one of
> the modifier keys.
> 
> With your change, I could not replace any selection with a 9, (, [, {,
> ' or ".  , because "Replace Expression With A New Expression" was
> eliminated, while at the same time "Connect Existing Expression To A
> New Expression" was overloaded (introduced a second ways to accomplish
> the same thing).
> 
> 
> On Sat, Nov 21, 2015 at 11:15 AM, marcel.taeumel <Marcel.Taeumel at hpi.de> wrote:
> > -1
> >
> > 1. This breaks the undo for #autoEnclose, which I had fixed on purpose.
> > 2. This removes a very convenient feature to put brackets around the current
> > selection.
> >
> > Please revert that commit or give a rationale. ;-) Or both.
> >
> > What is that use case "replace expression with new expression"? Just from
> > reading the words, it just worked fine.
> >
> > Best,
> > Marcel
> >
> >
> >
> > --
> > View this message in context: http://forum.world.st/The-Trunk-Morphic-cmm-1052-mcz-tp4862408p4862409.html
> > Sent from the Squeak - Dev mailing list archive at Nabble.com.
> >