[squeak-dev] The Trunk: Tools-cmm.634.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Oct 5 18:39:54 UTC 2015


Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.634.mcz

==================== Summary ====================

Name: Tools-cmm.634
Author: cmm
Time: 5 October 2015, 1:39:05.231 pm
UUID: 1b9e0e4c-f728-48ff-9046-54b7f7c302d0
Ancestors: Tools-cmm.620, Tools-eem.633

- IDE, please stop forcing a message category selection just because I accepted a method.  If I want that, I'll simply press the hot-key, Shift+Command+C.

=============== Diff against Tools-eem.633 ===============

Item was changed:
  ----- Method: Browser>>compileMessage:notifying: (in category 'code pane') -----
  compileMessage: aText notifying: aController
  	"Compile the code that was accepted by the user, placing the compiled method into an appropriate message category.  Return true if the compilation succeeded, else false."
- 
  	| fallBackCategoryName originalSelectorName result fallBackMethodName |
+ 	self selectedMessageCategoryName = ClassOrganizer allCategory
- 
- 	self selectedMessageCategoryName ifNil:
- 			[ self selectOriginalCategoryForCurrentMethod 	
- 										ifFalse:["Select the '--all--' category"
- 											self messageCategoryListIndex: 1]]. 
- 
- 
- 	self selectedMessageCategoryName asSymbol = ClassOrganizer allCategory
  		ifTrue:
  			[ "User tried to save a method while the ALL category was selected"
  			fallBackCategoryName := selectedMessageCategoryName.
  			fallBackMethodName := selectedMessageName.
  			editSelection == #newMessage
  				ifTrue:
  					[ "Select the 'as yet unclassified' category"
  					selectedMessageCategoryName := nil.
  					(result := self defineMessageFrom: aText notifying: aController)
  						ifNil:
  							["Compilation failure:  reselect the original category & method"
  							selectedMessageCategoryName := fallBackCategoryName.
  							selectedMessageName := fallBackMethodName]
  						ifNotNil:
  							[self setSelector: result]]
  				ifFalse:
  					[originalSelectorName := self selectedMessageName.
  					self setOriginalCategoryIndexForCurrentMethod.
  					selectedMessageName := fallBackMethodName := originalSelectorName.			
  					(result := self defineMessageFrom: aText notifying: aController)
  						ifNotNil:
  							[self setSelector: result]
  						ifNil:
  							[ "Compilation failure:  reselect the original category & method"
  							selectedMessageCategoryName := fallBackCategoryName.
  							selectedMessageName := fallBackMethodName.
  							^ result notNil]].
  			self changed: #messageCategoryList.
  			^ result notNil]
  		ifFalse:
  			[ "User tried to save a method while the ALL category was NOT selected"
  			^ (self defineMessageFrom: aText notifying: aController) notNil]!



More information about the Squeak-dev mailing list