[squeak-dev] Squeak 4.6: MonticelloConfigurations-dtl.137.mcz

Tobias Pape Das.Linux at gmx.de
Sun Oct 11 06:14:43 UTC 2015


Hi,

On 11.10.2015, at 00:21, commits at source.squeak.org wrote:

>  ----- Method: MCMcmUpdater class>>initialize (in category 'class initialization') -----
>  initialize
>  	"MCMcmUpdater initialize"
> - 	LastUpdateMap ifNil:[
> - 		LastUpdateMap := Dictionary new.
> - 	].
>  	DefaultUpdateURL ifNil:[
>  		DefaultUpdateURL := MCHttpRepository trunkUrlString.
>  	].
>  	Updaters := nil.
> - 	self flag: #FIXME.
> - 		"The next line is to faciliate updating from class-side methods to instance based.
> - 		Building a new default update map is very time consuming, so do not do it.
> - 		Delete this after the transition is complete. Also delete class var LastUpdateMap
> - 		and its initialization above. -dtl May 2015"
> - 	LastUpdateMap ifNotNil: [ self default lastUpdateMap: LastUpdateMap ]
>  !

Attention, this again kills all updates when this package is loaded!
So, 4.6 won't update correctly after this package (that is, it will
restart from map 0…)

See MonticelloConfigurations-topa.138

==================== Summary ====================

Name: MonticelloConfigurations-topa.138
Author: topa
Time: 24 September 2015, 2:48:24.846 pm
UUID: 153b9666-3723-4eb0-b230-7bc75450b892
Ancestors: MonticelloConfigurations-dtl.137

Do not nil out Updaters on initialize, beacuse this can screw the whole update process.

=============== Diff against MonticelloConfigurations-dtl.137 ===============

Item was changed:
 ----- Method: MCMcmUpdater class>>initialize (in category 'class initialization') -----
 initialize
 	"MCMcmUpdater initialize"
 	DefaultUpdateURL ifNil:[
 		DefaultUpdateURL := MCHttpRepository trunkUrlString.
 	].
+ 	"Call
+ 		MCMcmUpdater resetUpdaters
+ 	manually if necessary"!
- 	Updaters := nil.
- !

Item was added:
+ ----- Method: MCMcmUpdater class>>resetUpdaters (in category 'class initialization') -----
+ resetUpdaters
+ 
+ 	Updaters := nil.!

Best regards
	-Tobias


More information about the Squeak-dev mailing list