[squeak-dev] The Trunk: CollectionsTests-nice.255.mcz

David T. Lewis lewis at mail.msen.com
Sat Oct 31 19:54:34 UTC 2015


On Sat, Oct 31, 2015 at 08:45:44PM +0100, Tobias Pape wrote:
> 
> On 31.10.2015, at 17:39, commits at source.squeak.org wrote:
> 
> > Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk:
> > http://source.squeak.org/trunk/CollectionsTests-nice.255.mcz
> > 
> > ==================== Summary ====================
> > 
> > Name: CollectionsTests-nice.255
> > Author: nice
> > Time: 31 October 2015, 6:39:25.525 pm
> > UUID: 4f5361b3-18c8-47f1-ba59-030004683963
> > Ancestors: CollectionsTests-ul.254
> > 
> > In a 64bits spur VM, not all SmallInteger can be stored in an IntegerArray, It's time to document it.
> > 
> 
> Eh?
> Shouldn't we rather fix IntegerArray then?
> Best
> 	-Tobias
> 

No. From the class comment:

	IntegerArrays store 32bit signed Integer values.
	Negative values are stored as 2's complement.

Therefore the range of SmallInteger may now exceed the range of a
32bit twos complement integer, and this should be documented.

Dave



More information about the Squeak-dev mailing list