[squeak-dev] The Trunk: Morphic-cmm.1074.mcz

Chris Muller ma.chris.m at gmail.com
Fri Feb 12 01:48:26 UTC 2016


You're right, I should have asked first.  However, now I see there is
another for vertical, so lets talk about removing that one too.

The change occurred in Morphic-mt.893, the log entry mentions the coupling,
but doesn't say why other than "due to the nature of sliders", which I
disagree with.  hResizing is a property which can be set by any
application, as it needs.  Marcel, where you need it to be #spaceFill, we
can set from there.  My app needs to maintain control over this.

What was so bedevilling about this was how, because the Sliders owner was
#shrinkWrap, it would calculate to its #minExtent of 14 at 14, a [square], and
so it was guessing a vertical orientation (wrong), and so hResizing was
reporting my expected setting (#rigid) by the time UI got control back.

Do we still need SimpleSliderMorph or can I use Slider?

On Thu, Feb 11, 2016 at 6:26 PM, Tobias Pape <Das.Linux at gmx.de> wrote:

>
> On 12.02.2016, at 01:02, Chris Muller <asqueaker at gmail.com> wrote:
>
> > My God I just spent hours trying to find how / where layoutInBounds:
> > was arbitrarily setting my SimpleSliderMorphs hResizing to #spaceFill.
> > No amount of various print debugging statements in
> > Morph>>#layoutInBounds: and TableLayout>>layoutLeftToRight:in: were
> > helping.
> >
> > And then I saw this..  I have no idea why this was done but, its wrong
> > for the general case so, its gone.  If someone needs this
> > application-specific behavior they should add it as an extension to
> > their app.
> >
>
> Well, Marcel put it in just in April 2015:
> 'mt 4/17/2015 13:47'
> Maybe, if you asked, we'd all know why he put it there.
> I think the general problem here was that Scroll Bars have a very intimate
> relation to Sliders.
>
>
> > On Thu, Feb 11, 2016 at 5:53 PM,  <commits at source.squeak.org> wrote:
> >> Chris Muller uploaded a new version of Morphic to project The Trunk:
> >> http://source.squeak.org/trunk/Morphic-cmm.1074.mcz
> >>
> >> ==================== Summary ====================
> >>
> >> Name: Morphic-cmm.1074
> >> Author: cmm
> >> Time: 11 February 2016, 5:52:58.3338 pm
> >> UUID: db42c601-202c-4cc5-a2f8-2a8e45d77d12
> >> Ancestors: Morphic-mt.1073
> >>
> >> Remove arbitrary hResizing for horizontal Sliders.
> >>
> >> =============== Diff against Morphic-mt.1073 ===============
> >>
> >> Item was removed:
> >> - ----- Method: Slider>>hResizing (in category 'as yet unclassified')
> -----
> >> - hResizing
> >> -
> >> -       ^ self orientation == #horizontal
> >> -               ifTrue: [#spaceFill]
> >> -               ifFalse: [#rigid]!
> >>
> >>
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160211/644bb75f/attachment.htm


More information about the Squeak-dev mailing list