[squeak-dev] The Trunk: Kernel-mt.989.mcz

Bert Freudenberg bert at freudenbergs.de
Tue Feb 16 21:18:50 UTC 2016

> On 16.02.2016, at 09:28, commits at source.squeak.org wrote:
> Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
> http://source.squeak.org/trunk/Kernel-mt.989.mcz
> ==================== Summary ====================
> Name: Kernel-mt.989
> Author: mt
> Time: 16 February 2016, 10:28:16.317748 am
> UUID: c658e246-d184-42ce-83dd-7d6f40184726
> Ancestors: Kernel-mt.988
> Condense ways of peeking the mouse cursor position. Avoid flushing other mouse events when peeking the mouse position. Useful for the profiler.

Why would flushing the events *not* be wanted? When something uses Sensor directly then the mouse events buffered so far are useless and *should* be flushed.

> Note that it is still discouraged to peek the mouse position in Morphic code. We might want to upate all senders of #cursorPoint and #peekPosition.


>  ----- Method: EventSensor>>primMousePt (in category 'private') -----
>  primMousePt
>  	self fetchMoreEvents.
> + 	"self flushNonKbdEvents. -- mt: Should not be necessary here."
> - 	self flushNonKbdEvents.
>  	^ mousePosition!

I think the flush is necessary, and not harmful, so should be left in. Possibly with a comment.

- Bert -

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4207 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160216/df4a62ff/smime.bin

More information about the Squeak-dev mailing list