[squeak-dev] The Trunk: Files-cmm.159.mcz

Tobias Pape Das.Linux at gmx.de
Thu Jul 21 21:06:22 UTC 2016


On 21.07.2016, at 22:57, Chris Muller <asqueaker at gmail.com> wrote:

> This does change the return type in the case of a directory from a
> FileDirectory to a DirectoryEntryDirectory.
> 
> The intention is to gradually migrate most of FileDirectory's public
> api to DirectoryEntryDirectory, and let FileDirectory be concerned
> with the platform-specific access issues.
> 
> In the meantime, the most compatible thing to do for backward
> compatibility with the old #/ is to send #asFileDirectory to the
> result.


I'm not ok with this change.

It makes 

	FileDirectory default / 'myDir' / 'aSubDir' oldFileNamed: 'foo' do: [:stream | ..]	

unduly complex. 
If we were about to migrate, we should migrate to FileSytem, I'd say. :)

best regards
	-Tobias

> 
> 
> On Thu, Jul 21, 2016 at 3:44 PM,  <commits at source.squeak.org> wrote:
>> Chris Muller uploaded a new version of Files to project The Trunk:
>> http://source.squeak.org/trunk/Files-cmm.159.mcz
>> 
>> ==================== Summary ====================
>> 
>> Name: Files-cmm.159
>> Author: cmm
>> Time: 21 July 2016, 3:44:04.16263 pm
>> UUID: 52077283-7106-4ab6-8368-d5f4b5f6f641
>> Ancestors: Files-eem.158
>> 
>> Fix FileDirectory>>#/ to not assume the argument represents another directory; it could be a file.
>> 
>> =============== Diff against Files-eem.158 ===============
>> 
>> Item was changed:
>>  ----- Method: FileDirectory>>/ (in category 'path access') -----
>>  / aString
>>        "Answer a FileDirectory on a subdirectory named aString, of the receiver."
>> +       ^ FileDirectory directoryEntryFor: (self fullNameFor: aString)!
>> -       ^ FileDirectory on: (self fullNameFor: aString)!




More information about the Squeak-dev mailing list