[squeak-dev] The Trunk: Morphic-tpr.1168.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Jun 7 00:58:26 UTC 2016


tim Rowledge uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-tpr.1168.mcz

==================== Summary ====================

Name: Morphic-tpr.1168
Author: tpr
Time: 6 June 2016, 5:57:35.057325 pm
UUID: 25f07e8c-1f07-4c6f-86af-82ada954a115
Ancestors: Morphic-mt.1167

make the preferred position for compositing input window take into account any effect of height offset. Why work out the position and then modify it with ugly code when you can do it right first time?

=============== Diff against Morphic-mt.1167 ===============

Item was changed:
  ----- Method: TextMorph>>preferredKeyboardPosition (in category 'editing') -----
  preferredKeyboardPosition
- 
  	| default rects |
+ 	default := (self bounds: self bounds in: World) topLeft.
+ 	paragraph
+ 		ifNil: [^ default].
- 	default  := (self bounds: self bounds in: World) topLeft.
- 	paragraph ifNil: [^ default].
  	rects := paragraph selectionRects.
+ 	rects size = 0
+ 		ifTrue: [^ default].
+ 	^ rects first bottomLeft!
- 	rects size = 0 ifTrue: [^ default].
- 	^ rects first topLeft.
- 
- 	"^ (self bounds: self bounds in: World) topLeft."
- !

Item was changed:
  ----- Method: TextMorphForEditView>>preferredKeyboardPosition (in category 'event handling') -----
  preferredKeyboardPosition
  
  	| pos |
  	pos := super preferredKeyboardPosition.
+ 	^ pos + (self boundsInWorld) topLeft.
- 	^ pos + (self bounds: self bounds in: World) topLeft.
  !



More information about the Squeak-dev mailing list