[squeak-dev] The Trunk: Morphic-mt.842.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Wed May 4 15:48:25 UTC 2016


2015-04-08 20:26 GMT+02:00 <commits at source.squeak.org>:

> Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-mt.842.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-mt.842
> Author: mt
> Time: 8 April 2015, 8:26:35.712 pm
> UUID: 69b4e9ef-0563-9748-a5bf-fe69528f37b8
> Ancestors: Morphic-mt.841
>
> Made Slider more pluggable and thus removed PluggableSliderMorph from the
> system. The code that was not moved upwards into Slider was moved downwards
> into its sole subclass: BracketSliderMorph.
>
> It was verified that the "new color picker morph", which is the sole user
> of that BracketSliderMorph, stays functional.
>
> Why? The Slider should support custom min/max values whenever the default
> (floats with 0.0 to 1.0) is not appropriate. Truncation is supported, too.
> Everything was already present in the (removed) PluggableSliderMorph, but
> we need that behavior in ScrollBar.
>
> Note: There is still the SimpleSliderMorph, which duplicates some behavior
> of Slider but is a base class of slider. E-Toys uses it. We may want to
> remove that duplicated code later.
>
> =============== Diff against Morphic-mt.841 ===============
>
> Item was changed:
> + Slider subclass: #BracketSliderMorph
> +       instanceVariableNames: 'getEnabledSelector enabled'
> - PluggableSliderMorph subclass: #BracketSliderMorph
> -       instanceVariableNames: ''
>         classVariableNames: ''
>         poolDictionaries: ''
>         category: 'Morphic-Widgets'!
>
>   !BracketSliderMorph commentStamp: 'gvc 5/18/2007 13:39' prior: 0!
>   Abstract superclass for morphs that are used to select a component (R,
> G, B or A) of a colour.!
>
> Item was added:
> + ----- Method: BracketSliderMorph>>adoptPaneColor: (in category
> 'accessing - ui') -----
> + adoptPaneColor: paneColor
> +       "Pass on to the border too."
> +       super adoptPaneColor: paneColor.
> +       paneColor ifNil: [ ^ self ].
> +       self
> +                fillStyle: self fillStyleToUse ;
> +                borderStyle:
> +                       (BorderStyle inset
> +                                width: 1 ;
> +                                baseColor: self color twiceDarker) ;
> +                sliderColor:
> +                       (self enabled
> +                               ifTrue: [ paneColor twiceDarker ]
> +                               ifFalse: [ self paneColor twiceDarker
> paler ])!
>
> Item was added:
> + ----- Method: BracketSliderMorph>>borderStyleToUse (in category
> 'accessing - ui') -----
> + borderStyleToUse
> +       "Answer the borderStyle that should be used for the receiver."
> +
> +       ^self enabled
> +               ifTrue: [self theme sliderNormalBorderStyleFor: self]
> +               ifFalse: [self theme sliderDisabledBorderStyleFor: self]!
>
>
Hi Marcel,
theme?
There's no theme (yet) in Squeak...
Is it something that leaked from some other framework?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160504/b0d6ef70/attachment.htm


More information about the Squeak-dev mailing list