[squeak-dev] The Inbox: Graphics-dtl.335.mcz

Bert Freudenberg bert at freudenbergs.de
Thu May 12 12:12:58 UTC 2016


> On 12.05.2016, at 14:00, David T. Lewis <lewis at mail.msen.com> wrote:
> 
> On Thu, May 12, 2016 at 10:56:35AM +0200, Bert Freudenberg wrote:
>> On 12.05.2016, at 09:03, marcel.taeumel <Marcel.Taeumel at hpi.de> wrote:
>>> 
>>> Hi Dave,
>>> 
>>> no, the host window extent includes title bar and shadows in Windows 10.
>>> That's why I implemented DisplayScreen class >> #setNewScreenSize: with the
>>> two passes.
>>> 
>>> I copied this version over to trunk and adapted the calculation of the new
>>> screen size to use #hostWindowExtent and a single call.
>> 
>> I agree with Dave: We do not need or want to read hostWindowExtent. For the main window we already have actualScreenSize which gives us the extent.
>> 
>> We should set the window size to the expected value, check actualScreenSize, and adjust if needed to work around the Windows VM???s bug (and fix the Windows VM).
>> 
> 
> Thanks Marcel and Bert,
> 
> I added the DisplayScreen>>hostWindowExtent method in Graphics-dtl.335.
> If it is not needed, should I remove it? It is useful for exercising the
> HostWindowPlugin, but maybe it does not belong in trunk.

It is needed and used in HostWindowProxy. But for the main window we have actualScreenSize. That’s why I deleted it.

- Bert -



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4207 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160512/9791fbdd/smime.bin


More information about the Squeak-dev mailing list