[squeak-dev] The Trunk: Morphic-mt.1144.mcz

Chris Muller asqueaker at gmail.com
Fri May 13 15:44:37 UTC 2016


This broke Window Active On First Click.

All you needed to do was disable that.


On Fri, May 13, 2016 at 4:04 AM,  <commits at source.squeak.org> wrote:
> Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-mt.1144.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-mt.1144
> Author: mt
> Time: 13 May 2016, 11:04:30.317561 am
> UUID: af32b5c8-bcc6-9c47-90b2-8505917d5b94
> Ancestors: Morphic-kb.1143
>
> Fixes an older issue where it was not possible to set the keyboard focus of a text morph w/o discarding its selection. Most prominent in the System Browser where one could not simply overwrite the method template but had to re-select everything.
>
> This only affects users who disable "Focus follows mouse" and "mouseOverForKeyboardFocus".
>
> Here is the trick: Clicking inside the text morph's bounds still discards the selection. Embedded in a pluggable text morph, however, it is possible to click outside the text morph but inside the pluggable text morph. In this case, just do not handle the event except for context menu and keyboard focus.
>
> This does still not work for pluggable text morphs whose text morphs fill out the whole (scrollable) viewpoint.
>
> =============== Diff against Morphic-kb.1143 ===============
>
> Item was changed:
>   ----- Method: TextMorph>>mouseDown: (in category 'event handling') -----
>   mouseDown: evt
>         "Make this TextMorph be the keyboard input focus, if it isn't
>         already, and repond to the text selection gesture."
> +
> +       evt yellowButtonPressed ifTrue: [
> +               "First check for option (menu) click"
> +               ^ self yellowButtonActivity: evt shiftPressed].
> +
> -       evt yellowButtonPressed
> -               ifTrue: ["First check for option (menu) click"
> -                       ^ self yellowButtonActivity: evt shiftPressed].
>         evt hand newKeyboardFocus: self.
> +
> +       (self bounds containsPoint: evt position) ifTrue: [
> +               self
> +                       handleInteraction: [editor mouseDown: evt]
> +                       fromEvent: evt].!
> -       self
> -               handleInteraction: [editor mouseDown: evt]
> -               fromEvent: evt.
> - !
>
>


More information about the Squeak-dev mailing list