Ok, it only fails if MCMethodDefinition>>mcModel is nil in
MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference

Once you have the MCMethodDefinition>>mcModel installed it will work the
next time, so my fix is still necessary



Best,
Karl

On Tue, May 24, 2016 at 6:41 PM, karl ramberg <karlramberg at gmail.com> wrote:

> Hm, weird.
> I removed the fix I did and now it works...
>
> Not sure what was going on
>
> Best,
> Karl
>
> On Tue, May 24, 2016 at 6:33 PM, Bert Freudenberg <bert at freudenbergs.de>
> wrote:
>
>> Which menu item are you trying? You wrote “can open a browser from the
>> context menu” and for me both cmd-b and the context menu work for opening a
>> System Browser.
>>
>> - Bert -
>>
>>
>> On 24.05.2016, at 18:27, karl ramberg <karlramberg at gmail.com> wrote:
>>
>>
>> I know packageInfo is not the same as workingCopy but I'm not sure how to
>> reference it from the merge browser.
>>
>> How can this be working in your image ? packageInfo is not implemented
>> for MCMethodDefinition...
>>
>>
>> It's called from
>> MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference
>> ^ aClassOrMethodReference mcModel ifNil:
>> [ | pkgName rep | (UIManager confirm: 'Okay to add historical repository
>> ' , (rep := MCHttpRepository trunkBackup) description , ' to ' , (pkgName
>> := aClassOrMethodReference packageInfo packageName) , '?') ifTrue:
>> [ (MCWorkingCopy forPackageNamed: pkgName) repositoryGroup addRepository:
>> rep.
>> aClassOrMethodReference mcModel ] ]
>>
>> Best,
>> Karl
>>
>> On Tue, May 24, 2016 at 5:56 PM, Bert Freudenberg <bert at freudenbergs.de>
>> wrote:
>>
>>> On 24.05.2016, at 17:17, karl ramberg <karlramberg at gmail.com> wrote:
>>> >
>>> > I'm pretty sure this is a proper fix so the MCMergeBrowser can open a
>>> browser from the context menu:
>>>
>>> This appears to work fine for me even without that change.
>>>
>>> > MCMethodDefinition>>packageInfo
>>> >
>>> >        ^ self workingCopy! !
>>>
>>> … and a WorkingCopy most definitely is not the same as a PackageInfo ;)
>>>
>>> - Bert -
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20160524/6d8f80f2/attachment.htm