[squeak-dev] Re: raised & inset borders

tim Rowledge tim at rowledge.org
Thu Nov 3 23:48:53 UTC 2016


Didn’t my fix for this get into the update stream? A few weeks back I hit this ‘bug’ and suggested simply not initialising baseColor at all. 
With it left nil, any use of trackColorFrom: is able to set the inset colour ok.

> On 03-11-2016, at 3:22 PM, Levente Uzonyi <leves at caesar.elte.hu> wrote:
> 
> Hi Hans-Martin,
> 
> My intention was to always initialize baseColor, because nil was used as a substitute of Color transparent back and forth for seemingly no reason.
> I must have overlooked those #trackColorFrom: methods, and I think replacing ifNil: with isTransparent ifTrue: in them is the right fix.
> If you have a better solution in mind, let me know. Or I'll push the above fix this week to the Trunk.
> 
> Levente
> 
> On Tue, 1 Nov 2016, Hans-Martin Mosner wrote:
> 
>> Looks like there is a regression with raised and inset borders. The method #initialize in SimpleBorder sets baseColor to
>> "Color transparent", which prevents #trackColorFrom: in its subclasses to work correctly.
>> 
>> Since it is unclear to me whether it would have unintended side effects if the initialization of baseColor was removed,
>> I've added a check for transparent baseColor in all three trackColorFrom: methods, but that looks a bit ugly.
>> 
>> Levente, the method is from April 2016 and carries your initials - do you remember what the motivation for this change was?
>> 
>> 
>> Cheers,
>> 
>> Hans-Martin
>> 
>> 
>> 
> 


tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Fractured Idiom:- LE ROI EST MORT. JIVE LE ROI - The King is dead.  No kidding.




More information about the Squeak-dev mailing list