[squeak-dev] The Trunk: Monticello-bf.656.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Nov 25 11:18:00 UTC 2016


Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-bf.656.mcz

==================== Summary ====================

Name: Monticello-bf.656
Author: bf
Time: 25 November 2016, 12:17:47.494828 pm
UUID: b1f7d626-c985-4400-9d5e-4cc68459b1cf
Ancestors: Monticello-bf.655

Don't shadow 'label' var. Also, rename single use of "editions".

=============== Diff against Monticello-bf.655 ===============

Item was removed:
- ----- Method: MCOperationsBrowser>>isViewingEditions (in category 'accessing') -----
- isViewingEditions
- 	^self items size > 1 and:
- 		[self items allSatisfy:
- 			[:each | each definition isRevisionOf: self items first definition]]!

Item was added:
+ ----- Method: MCOperationsBrowser>>isViewingRevisions (in category 'accessing') -----
+ isViewingRevisions
+ 	^self items size > 1 and:
+ 		[self items allSatisfy:
+ 			[:each | each definition isRevisionOf: self items first definition]]!

Item was changed:
  ----- Method: MCOperationsBrowser>>list (in category 'accessing') -----
  list
  	| showRevision |
+ 	showRevision := self isViewingRevisions.
+ 	^ self items collect: [:each | | summary |
+ 		summary := showRevision ifTrue: [each summaryAndRevision] ifFalse: [each summary].
- 	showRevision := self isViewingEditions.
- 	^ self items collect: [:each | | label |
- 		label := showRevision ifTrue: [each summaryAndRevision] ifFalse: [each summary].
  		(self reverts includes: each)
+ 			ifFalse: [summary]
- 			ifFalse: [label]
  			ifTrue: [Text
+ 				string: '( ', summary, ' )'
- 				string: '( ', label, ' )'
  				attributes: (self userInterfaceTheme revertedOperationAttributes ifNil: [{TextEmphasis struckOut}])]]!



More information about the Squeak-dev mailing list