Hi Chris,

thanks for looking into this! ExternalForm is not used by Etoys, so it
should just be removed along with the test. I guess it's a leftover from
Balloon3D.

For the FFI package, you could submit a fixed version to the Inbox and any
core developer can move it to the FFI repo.

- Bert -

On Mon, Apr 17, 2017 at 6:49 PM, Chris Cunningham <cunningham.cb at gmail.com>
wrote:

> Hi.
>
> If someone could also either give me access to source.squeag.org/FFI or
> remove this test from that repository as well, I'd appreciate it.
> This test was failing in the FFI test suite because there was no longer a
> need to send #allocateSpace on ExternalForm.  It is (was?) also incorrectly
> located - test in FFI, form now in EToys.
>
> This should fix moving the test and fixing it (if moved to trunk); the
> final piece is to remove it from FFI.
>
> Thanks,
> -cbc
>
> On Mon, Apr 17, 2017 at 9:44 AM, <commits at source.squeak.org> wrote:
>
>> A new version of EToys was added to project The Inbox:
>> http://source.squeak.org/inbox/EToys-cbc.293.mcz
>>
>> ==================== Summary ====================
>>
>> Name: EToys-cbc.293
>> Author: cbc
>> Time: 17 April 2017, 9:44:25.306187 am
>> UUID: 7f27f8f3-1ad3-9d4b-a359-1b085c98e5c2
>> Ancestors: EToys-nice.292
>>
>> Moved ExternalForm test from FFI package here - since the ExternalForm is
>> now in this package.
>> Also, fixed test.
>>
>> =============== Diff against EToys-nice.292 ===============
>>
>> Item was added:
>> + TestCase subclass: #EtoysExternalFormTest
>> +       instanceVariableNames: ''
>> +       classVariableNames: ''
>> +       poolDictionaries: ''
>> +       category: 'Etoys-Tests'!
>>
>> Item was added:
>> + ----- Method: EtoysExternalFormTest>>testBlitToAndFromExternalForm (in
>> category 'as yet unclassified') -----
>> + testBlitToAndFromExternalForm
>> +       "Ensure that we can blit to/from all 4 permutatations of Form and
>> ExternalForm."
>> +       | source external1 external2 destination |
>> +       source := Cursor wait asCursorForm asFormOfDepth: 32.
>> +       destination := Form extent: source extent depth: 32.
>> +       external1 := ExternalForm extent: source extent depth: 32.
>> +       external2 := ExternalForm extent: source extent depth: 32.
>> +       self shouldnt: [source bits = destination bits].
>> +       source displayOn: external1.
>> +       external1 displayOn: external2.
>> +       external2 displayOn: destination.
>> +       self should: [source bits = destination bits].!
>>
>>
>>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170417/ba1b69e4/attachment.html>