[squeak-dev] The Inbox: Morphic-dtl.1376.mcz

David T. Lewis lewis at mail.msen.com
Mon Dec 11 13:38:51 UTC 2017


I think that it wlll work with the most recent versions of Morphic-dtl.1376,
ST80-dtl.233, and System-dtl.983 in the inbox.

I'll check it later tonight to make sure.

I moved the "SoundService stop" from Project>>finalExitActions: to
MVCProject>>finalExitActions: so that it would not affect Morphic, which
handles it differently (and the Morphic handling would not work for MVC
or SqueakShellProject).

I'm not sure if SoundService is important in a SqueakShellProject, but
if so, it would be necessary to add the "SoundService stop" to
SqueakShellProject>>finalExitActions:.

So maybe it would be better to leave the SoundService handling as it was?
In that case we could add handling for EmergencyRecoveryRequested in
MorphicProject>>finalExitActions:. But overall I think I prefer calling
super in the that method, although I cannot really give any good reason
for preferring it.

Thanks for looking that this :-)

Thanks,
Dave 

On Mon, Dec 11, 2017 at 07:48:25AM +0100, Marcel Taeumel wrote:
> Hmm... now #letTheMusicPlay cannot work anymore. :-)
> 
> Best,
> Marcel
> Am 10.12.2017 20:07:19 schrieb commits at source.squeak.org <commits at source.squeak.org>:
> David T. Lewis uploaded a new version of Morphic to project The Inbox:
> http://source.squeak.org/inbox/Morphic-dtl.1376.mcz
> 
> ==================== Summary ====================
> 
> Name: Morphic-dtl.1376
> Author: dtl
> Time: 10 December 2017, 2:04:07.58309 pm
> UUID: eaa7809b-73bf-4643-b2a1-3d9d7ac54362
> Ancestors: Morphic-nice.1375
> 
> Call super in finalExitActions: in order to clear the EmergencyRecoveryRequested guard.
> 
> =============== Diff against Morphic-nice.1375 ===============
> 
> Item was changed:
> ----- Method: MorphicProject>>finalExitActions: (in category 'enter') -----
> finalExitActions: enteringProject
> 
> + super finalExitActions: enteringProject.
> world triggerClosingScripts.
> -
> "Pause sound players, subject to preference settings"
> (world hasProperty: #letTheMusicPlay)
> ifTrue: [world removeProperty: #letTheMusicPlay]
> ifFalse: [SoundService stop].
> 
> world sleep.
> (world findA: ProjectNavigationMorph)
> ifNotNil: [:navigator | navigator retractIfAppropriate].
> self clearGlobalState.
> Sensor flushAllButDandDEvents. !
> 
> 

> 



More information about the Squeak-dev mailing list