[squeak-dev] [sqeak-dev] Latest updates, dark themes don't look so good

Chris Cunningham cunningham.cb at gmail.com
Wed Feb 1 22:09:10 UTC 2017


So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in method
MorphicToolBuilder>>buildPluggableTree:, where it sends:
widget color: Preferences defaultBackgroundColor.
This if after the theme-based setting of the color, so it overrides
whatever the theme wants it to be.

Fix in the inbox, in:
    ToolBuilder-Morphic-cbc.191
Basically, I just removed the override of the color, to let the theme color
be used instead.

(as an aside, I'm not sure why in a selected dark theme, the
defualtBackgroundColor is "veryVeryLightGray").

-cbc

On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <cunningham.cb at gmail.com>
wrote:

> Hmm.  This only happens when i open a new explorer.  If I open an
> explorer, then change normal squeak theme, then go back to Monokai(dark),
> the tree view is now dark (like I would expect).  But the next explorer
> will have the white background again.
>
> -cbc
>
> On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <cunningham.cb at gmail.com
> > wrote:
>
>> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
>> image (16548), things like inspectors are readable:
>> [image: Inline image 1]
>> while in a post-etoys updated 6.0Alpha image (16903), these inspectors
>> are nearly useless:
>> [image: Inline image 2]
>> It may be that I had tweaked the colors in the older image, or loaded a
>> different code where someone else fixed it. I'll look for where the change
>> came from, but if someone knows what to fix, I'd appreciate that.
>>
>> -cbc
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170201/a456cde9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 7599 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170201/a456cde9/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 11470 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170201/a456cde9/attachment-0001.png>


More information about the Squeak-dev mailing list