[squeak-dev] [sqeak-dev] Latest updates, dark themes don't look so good

David T. Lewis lewis at mail.msen.com
Thu Feb 2 23:58:44 UTC 2017


Good. And however it got into trunk, thanks for the fix :-)

I moved ToolBuilder-Morphic-cbc.191 (with just that one method) over to
the treated inbox.

Dave

On Thu, Feb 02, 2017 at 02:38:16PM -0800, Chris Cunningham wrote:
> I think you may be correct.
> 
> What I suspect happened is that I had loaded the Theme SAR before this was
> put into trunk, and when I migrated up afterwards, somehow it didn't
> migrate nicely.
> In any case, what is in Trunk is what I proposed (with slightly different
> formatting - but same code).
> 
> Sorry for the disruption.
> 
> -cbc
> 
> On Wed, Feb 1, 2017 at 6:03 PM, David T. Lewis <lewis at mail.msen.com> wrote:
> 
> > I'm confused, the new version of MorphicToolBuilder>>buildPluggableTree:
> > from the inbox looks the same as the method currently in my trunk image,
> > and I am not able to reproduce the problem with explorers in dark theme.
> >
> > Is there a version mixup here? Or maybe someone already merged the fix?
> >
> > Dave
> >
> > On Wed, Feb 01, 2017 at 02:09:10PM -0800, Chris Cunningham wrote:
> > > So, tracking this down, it was a change in 2/5/2016 (?) from kfr, in
> > method
> > > MorphicToolBuilder>>buildPluggableTree:, where it sends:
> > > widget color: Preferences defaultBackgroundColor.
> > > This if after the theme-based setting of the color, so it overrides
> > > whatever the theme wants it to be.
> > >
> > > Fix in the inbox, in:
> > >     ToolBuilder-Morphic-cbc.191
> > > Basically, I just removed the override of the color, to let the theme
> > color
> > > be used instead.
> > >
> > > (as an aside, I'm not sure why in a selected dark theme, the
> > > defualtBackgroundColor is "veryVeryLightGray").
> > >
> > > -cbc
> > >
> > > On Tue, Jan 31, 2017 at 5:06 PM, Chris Cunningham <
> > cunningham.cb at gmail.com>
> > > wrote:
> > >
> > > > Hmm.  This only happens when i open a new explorer.  If I open an
> > > > explorer, then change normal squeak theme, then go back to
> > Monokai(dark),
> > > > the tree view is now dark (like I would expect).  But the next explorer
> > > > will have the white background again.
> > > >
> > > > -cbc
> > > >
> > > > On Tue, Jan 31, 2017 at 9:52 AM, Chris Cunningham <
> > cunningham.cb at gmail.com
> > > > > wrote:
> > > >
> > > >> I don't know where this happened, but in a pre-etoys-updated 6.0Alpha
> > > >> image (16548), things like inspectors are readable:
> > > >> [image: Inline image 1]
> > > >> while in a post-etoys updated 6.0Alpha image (16903), these inspectors
> > > >> are nearly useless:
> > > >> [image: Inline image 2]
> > > >> It may be that I had tweaked the colors in the older image, or loaded
> > a
> > > >> different code where someone else fixed it. I'll look for where the
> > change
> > > >> came from, but if someone knows what to fix, I'd appreciate that.
> > > >>
> > > >> -cbc
> > > >>
> > > >
> > > >
> >
> >
> >
> >
> > >
> >
> >
> >

> 



More information about the Squeak-dev mailing list