[squeak-dev] The Trunk: Morphic-eem.1340.mcz

Eliot Miranda eliot.miranda at gmail.com
Sat Jun 3 17:18:25 UTC 2017


Hi Jacob,

> On Jun 3, 2017, at 2:32 AM, Jakob Reschke <jakob.reschke at student.hpi.de> wrote:
> 
> 2017-06-01 22:22 GMT+02:00 commits at source.squeak.org
> <commits at source.squeak.org>:
>> Eliot Miranda uploaded a new version of Morphic to project The Trunk:
>> http://source.squeak.org/trunk/Morphic-eem.1340.mcz
>> 
>> =============== Diff against Morphic-eem.1339 ===============
>> 
>> +                       (anEntry isBehavior and: [anEntry name == aSymbol]) ifFalse: "When is this ever false?"
>> +                               [anEntry := anEntry class].
>> -                       (anEntry isKindOf: Class)
>> -                               ifFalse:        [anEntry := anEntry class].
> 
> How nice, this saves me a tour to the inbox. Now you can hassle-freely
> go to traits mentioned in a uses: clause via browseIt, instead of
> being taken to the class Trait.

Good!

> 
> The condition is false for globals such as Smalltalk and SystemOrganization.

Right.  I meant when is anEntry name == aSymbol false.  Smalltalk and SystemOrganization are not classes so no issue.  So the issue is traits.  Do you  want to update the comment here?


More information about the Squeak-dev mailing list