Hi Levente,

On Tue, Mar 21, 2017 at 9:46 AM, Eliot Miranda <eliot.miranda at gmail.com>
wrote:

> Hi Levente,
>
>     please revert the change that eliminates the argument counts from the
> specialSelectors array ASAP.  The VM uses these!!  This is causing untold
> damage in the VM as we speak (for example, it is related to Hernan's
> crash).  The VM *must* be able to determine the argument count for a
> special selector it does not inline.
>

Ah, OK.  It's not creating damage in the VM, but it is creating damage in
the simulator.  Forgive me :-).  I overreacted.


>
> On Sun, Mar 19, 2017 at 4:35 PM, <commits at source.squeak.org> wrote:
>
>> Levente Uzonyi uploaded a new version of System to project The Trunk:
>> http://source.squeak.org/trunk/System-ul.937.mcz
>>
>> ==================== Summary ====================
>>
>> Name: System-ul.937
>> Author: ul
>> Time: 20 March 2017, 12:35:03.813931 am
>> UUID: 01691bb8-181f-4795-83ce-20130031a81d
>> Ancestors: System-ul.936
>>
>> Fixed SmalltalkImage >> #specialSelectors. SystemTracer doesn't use it
>> any more, but it's being used by tests, which expect it to return only the
>> selectors without their argument count.
>>
>> =============== Diff against System-ul.936 ===============
>>
>> Item was changed:
>>   ----- Method: SmalltalkImage>>specialSelectors (in category 'special
>> objects') -----
>>   specialSelectors
>> +
>> +       | arrayOfPairs |
>> +       arrayOfPairs := self specialObjectsArray at: 24.
>> +       ^Array new: arrayOfPairs size // 2 streamContents: [ :stream |
>> +               arrayOfPairs pairsDo: [ :selector :numArgs |
>> +                       stream nextPut: selector ] ]
>> + !
>> -       "Used by SystemTracer only."
>> -
>> -       ^SpecialSelectors!
>>
>>
>>
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>



-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170321/3b8f8b2a/attachment.html>