[squeak-dev] More cruft

David T. Lewis lewis at mail.msen.com
Wed Mar 29 23:16:18 UTC 2017


It probably made some sense in providing a uniform protocol when small integers
were the only immediates, but now it is more likely to just obscure the actual
implementions. If it was used in VMMaker you (Eliot) would have noticed by now,
and Levente says it's not used anywhere else. I checked an old Squeak 2.0 image,
and I do not see any places where it would matter even back then.

So I would say let it go.

Dave


On Wed, Mar 29, 2017 at 11:25:50PM +0200, Levente Uzonyi wrote:
> I went through the senders of #instVarAt: in the base image, and found 
> that this feature is never used. Sends are guarded by #instSize, or the 
> receiver is self or a well-known pointers object.
> 
> Levente
> 
> On Wed, 29 Mar 2017, Eliot Miranda wrote:
> 
> >Hi All,
> >?? ?? another dubious piece of code is this:
> >
> >SmallInteger>>instVarAt: i?? "Small integer has to be specially handled."
> >
> >i = 1 ifTrue: [^self].
> >self error: 'argument too big for small integer instVarAt:'
> >
> >Either this is important and should be replicated in Character and 
> >SmallFloat64 (the other two immediate classes) or it should be 
> >discarded.?? It's
> >ancient (pre version stamps).?? I vote to nuke it.?? Opinions?
> >_,,,^..^,,,_
> >best,??Eliot
> >
> >

> 



More information about the Squeak-dev mailing list