[squeak-dev] The Trunk: Morphic-tpr.1353.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Oct 22 01:07:27 UTC 2017

tim Rowledge uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-tpr.1353
Author: tpr
Time: 21 October 2017, 6:07:05.387865 pm
UUID: aee97523-13a7-4829-8da8-95cd50fd8d15
Ancestors: Morphic-dtl.1352

Small cleanup for #browseIt

=============== Diff against Morphic-dtl.1352 ===============

Item was changed:
  ----- Method: TextEditor>>browseIt (in category 'menu messages') -----
  	"Launch a browser for the current selection, if appropriate"
+ 	| aSymbol anEntry maybeBrowseInstVar |
- 	| aSymbol anEntry brow maybeBrowseInstVar |
  	Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt].
  	self lineSelectAndEmptyCheck: [^ self].
+ 	maybeBrowseInstVar := [ | selectionString |
- 	maybeBrowseInstVar :=
- 		[| selectionString |
  		selectionString := self selection asString.
  		 ([model selectedClass] on: Error do: [:ex|]) ifNotNil:
  			(class allInstVarNames includes: selectionString) ifTrue:
  				[self systemNavigation
  					browseAllAccessesTo: selectionString
  					from: (class classThatDefinesInstanceVariable: selectionString).
  	(aSymbol := self selectedSymbol) ifNil:
  		[maybeBrowseInstVar value.
  		 ^morph flash].
  	aSymbol first isUppercase
  			[anEntry := (model environment
  				valueOf: aSymbol
  					[ ([model selectedClass] on: Error do: [:ex|]) ifNotNil:
  						(class bindingOf: aSymbol) ifNotNil: "e.g. a class var"
  							self systemNavigation browseAllCallsOn: binding.
  							^ nil]].
  					self systemNavigation browseAllImplementorsOf: aSymbol.
  					^ nil]).
  			anEntry ifNil: [^ morph flash].
  			(anEntry isBehavior and: [anEntry name == aSymbol]) ifFalse: "When is this ever false?"
  				[anEntry := anEntry class].
+ 			self systemNavigation browseClass: anEntry]
- 			brow := SystemBrowser default new.
- 			brow setClass: anEntry selector: nil.
- 			brow class
- 				openBrowserView: (brow openEditString: nil)
- 				label: 'System Browser']
  			[self systemNavigation browseAllImplementorsOf: aSymbol.
  			 maybeBrowseInstVar value]!

More information about the Squeak-dev mailing list