[squeak-dev] [Please Test] Refactoring for BorderedMorph to use BorderStyle

karl ramberg karlramberg at gmail.com
Thu Apr 19 20:04:32 UTC 2018


Hm,
Actually broken in 5.0
Image conversion issue ??
Best,
Karl

On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <karlramberg at gmail.com> wrote:

> Well,
> These border styles have been broken for some time.
> I checked some old images and it worked in the 4.6 image but not in 5.1 so
> something changed between there :-)
>
> Best,
> Karl
>
> On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <marcel.taeumel at hpi.de>
> wrote:
>
>> Well, they kind of work if you set the #baseColor in the respective
>> border style. Otherwise, yes, I noticed that, too. At least the Mines game
>> draws the fields on its own. So, there might be a bug hidden in drawing
>> those border styles.
>>
>> Best,
>> Marcel
>>
>> Am 18.04.2018 20:31:31 schrieb karl ramberg <karlramberg at gmail.com>:
>> Hi,
>>
>> #inset and #raised does not work either with or without Marcels changeset.
>>
>> Best,
>> Karl
>>
>>
>> On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <karlramberg at gmail.com>
>> wrote:
>>
>>> Hi,
>>> Slightly off topic:
>>> I have been looking at border stuff in latest Trunk image and I can't
>>> get border #inset and #raised to work.
>>>
>>> The complex borders work.
>>>
>>> Best,
>>> Karl
>>>
>>>
>>> On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <marcel.taeumel at hpi.de>
>>> wrote:
>>>
>>>> Thanks Karl and Dave. Chris, does it work in your image(s)?
>>>>
>>>> Best,
>>>> Marcel
>>>>
>>>> Am 14.04.2018 21:00:55 schrieb David T. Lewis <lewis at mail.msen.com>:
>>>> On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
>>>> > Anybody? Just file it in your work image and tell me what happens.
>>>> >
>>>>
>>>> Sorry I overlook this. I filed the changes in earlier today. All is
>>>> well with browsers and such, but when I open an Elipse from the Objects
>>>> tab, then rotate it with the halo handle, things go wrong. It looks
>>>> like the 'closed' instance variable in the PolygonMorph is nil.
>>>>
>>>> I think you may have already addressed this from Karl's report.
>>>>
>>>> Dave
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20180419/b128f6c4/attachment.html>


More information about the Squeak-dev mailing list