[squeak-dev] The Inbox: Tools-LM.829.mcz
David T. Lewis
lewis at mail.msen.com
Fri Aug 17 22:41:03 UTC 2018
Thanks for that fix. Your Tools-LM.829 contains just the one method change,
as you intended.
Your update should be moved from inbox to trunk, because it is part of the
Tools-cmm.826 -> Tools-tcj.827 -> Tools-LM.828 -> Tools-LM.829 -> Tools-dtl.830 -> Tools-cmm.831
Tools.cmm.826 -> Tools-eem.827 -> Tools-cmm.828 -> Tools-eem.829 -> Tools-dtl.830 -> Tools-cmm.831
I will wait a day or so and then move Tools-tcj.827 from inbox to trunk
so that it is part of the trunk update history.
If someone is looking for a cool project, a Monticello version branch
visualizer based on Connectors would be a great thing to have.
On Fri, Aug 17, 2018 at 11:39:44AM -0700, Tim Johnson wrote:
> I think my contribution Tools-tcj.827.mcz included another method change
> by mistake (due to a difference between my image and trunk, perhaps) and
> should be discarded.
> The only change I intended to share was the reversion (revert) of
> FileContentsBrowser>>#browseVersions .
> On 2018-08-17 09:37, David T. Lewis wrote:
> >Thanks Tim,
> >This sounds like Tools-tcj.827.mcz in the inbox. I had not intended to
> >include that in this merge, but I may have done so by accident.
> >Chris, if you're looking at this, please say if you think the two
> >from Tools-tcj.827 belong in trunk. If yes, we can move
> >to trunk so that the record is complete; if no, the two methods can be
> >reverted and considered later after the 5.2 release.
> >>>On Aug 16, 2018, at 2:41 PM, Chris Muller <asqueaker at gmail.com>
> >>>>+1. Merge now. It won??????t break anything.
> >>>The date on the methods is _yesterday_, are you really comfortable
> >>>making such a statement?
> >>>So what about FileContentsBrowser>>#browseVersions? Looks like it
> >>>rolled back to Doug Way's version from 2000 to no longer use your
> >>>2016 update to use ToolSet. But please, just let me know, don't
> >>>commit any more versions yet, 'cuz I see some other issues..
> >>This sounds like a contribution I made. #browseVersions in
> >>FileContentsBrowser cannot use the 2016 update to use ToolSet. It
> >>work. Try it for yourself.
> >>Reverting to the 2000 version allows it to work again.
More information about the Squeak-dev