[squeak-dev] The Trunk: Tools-mt.791.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Jan 16 16:53:45 UTC 2018


Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.791.mcz

==================== Summary ====================

Name: Tools-mt.791
Author: mt
Time: 16 January 2018, 5:52:57.329363 pm
UUID: a4ab8e7b-6130-9843-a27f-91456a171e78
Ancestors: Tools-eem.790

Small layout fixes in our new file/folder choose dialogs.

=============== Diff against Tools-eem.790 ===============

Item was changed:
  ----- Method: DirectoryChooserDialog>>buildWith: (in category 'toolbuilder') -----
  buildWith: builder
  	"assemble the spec for the chooser dialog UI"
  
  	| windowSpec window |
  	windowSpec := self buildWindowWith: builder specs: {
  		(self frameOffsetFromTop: 0
  			fromLeft: 0
  			width: 1
+ 			offsetFromBottom: 0) -> [self buildDirectoryTreeWith: builder].
- 			offsetFromBottom: self buttonHeight) -> [self buildDirectoryTreeWith: builder].
  	}.
+ 	windowSpec buttons addAll: ( self buildButtonsWith: builder ).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Accept';
- 						action: #acceptFileName).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Cancel';
- 						action: #cancelFileChooser).
  	window := builder build: windowSpec.
  	self changed: #selectedPath.
  	^window
  !

Item was added:
+ ----- Method: FileAbstractSelectionDialog>>buildButtonsWith: (in category 'toolbuilder') -----
+ buildButtonsWith: builder
+ 
+ 	^ {
+ 		builder pluggableButtonSpec new
+ 				model: self;
+ 				label: 'Accept' translated;
+ 				color: (self userInterfaceTheme get: #okColor for: #DialogWindow);
+ 				action: #acceptFileName.
+ 		builder pluggableButtonSpec new
+ 				model: self;
+ 				label: 'Cancel';
+ 				color: (self userInterfaceTheme get: #cancelColor for: #DialogWindow);
+ 				action: #cancelFileChooser}!

Item was changed:
  ----- Method: FileAbstractSelectionDialog>>buildWindowWith: (in category 'toolbuilder') -----
  buildWindowWith: builder
  	"Since a file chooser is a modal dialog we over-ride the normal window build to use a dialog as the top component"
  
  	| windowSpec |
  	windowSpec := builder pluggableDialogSpec new.
  	windowSpec model: self;
  				label: #windowTitle;
  				message: #userMessage;
  				extent: self initialExtent;
+ 				spacing: self viewSpacing;
  				children: OrderedCollection new;
  				buttons: OrderedCollection new.
  	^windowSpec!

Item was added:
+ ----- Method: FileAbstractSelectionDialog>>viewSpacing (in category 'ui details') -----
+ viewSpacing
+ 
+ 	^ 5 "pixels"!

Item was changed:
  ----- Method: FileChooserDialog>>buildWith: (in category 'toolbuilder') -----
  buildWith: builder
  	"assemble the spec for the chooser dialog UI"
  
  	| windowSpec window |
  	windowSpec := self buildWindowWith: builder specs: {
  		(self frameOffsetFromTop: 0
  			fromLeft: 0.25
  			width: 0.75
+ 			offsetFromBottom: 0) -> [self buildFileListWith: builder].
- 			offsetFromBottom: self buttonHeight) -> [self buildFileListWith: builder].
  		(self frameOffsetFromTop: 0
  			fromLeft: 0
  			width: 0.25
+ 			offsetFromBottom: 0) -> [self buildDirectoryTreeWith: builder].
- 			offsetFromBottom: self buttonHeight) -> [self buildDirectoryTreeWith: builder].
  	}.
+ 	windowSpec buttons addAll: ( self buildButtonsWith: builder ).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Accept';
- 						action: #acceptFileName).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Cancel';
- 						action: #cancelFileChooser).
  	window := builder build: windowSpec.
  	self changed: #selectedPath.
  	^window
  !

Item was changed:
  ----- Method: FileSaverDialog>>buildWith: (in category 'toolbuilder') -----
  buildWith: builder
  	"assemble the spec for the saver dialog UI and build the window"
  
  	| window windowSpec |
  	windowSpec := self buildWindowWith: builder specs: {
+ 		(self topConstantHeightFrame: self textViewHeight + self viewSpacing
- 		(self topConstantHeightFrame: self textViewHeight
  			fromLeft: 0
  			width: 1) -> [self buildTextInputWith: builder].
+ 		(self frameOffsetFromTop: self textViewHeight + self viewSpacing
- 		(self frameOffsetFromTop: self textViewHeight
  			fromLeft: 0.25
  			width: 0.75
+ 			offsetFromBottom: 0) -> [self buildFileListWith: builder].
+ 		(self frameOffsetFromTop: self textViewHeight + self viewSpacing
- 			offsetFromBottom: self buttonHeight) -> [self buildFileListWith: builder].
- 		(self frameOffsetFromTop: self textViewHeight
  			fromLeft: 0
  			width: 0.25
+ 			offsetFromBottom: 0) -> [self buildDirectoryTreeWith: builder].
- 			offsetFromBottom: self buttonHeight) -> [self buildDirectoryTreeWith: builder].
  	}.
+ 	windowSpec buttons addAll: ( self buildButtonsWith: builder ).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Accept';
- 						action: #acceptFileName).
- 	windowSpec buttons add:( builder pluggableButtonSpec new
- 						model: self;
- 						label: 'Cancel';
- 						action: #cancelFileChooser).
  	window := builder build: windowSpec.
  	self changed: #selectedPath.
  	self inputText: fileName.
  	^window
  !



More information about the Squeak-dev mailing list