[squeak-dev] The Trunk: Tools-cmm.823.mcz
David T. Lewis
lewis at mail.msen.com
Tue Jun 26 02:20:05 UTC 2018
On Mon, Jun 25, 2018 at 07:04:12PM -0500, Chris Muller wrote:
> On Mon, Jun 25, 2018 at 6:40 PM, David T. Lewis <lewis at mail.msen.com> wrote:
> > This is probably just a mistake, or something missing from the commit.
> > But until that can be sorted out, the Tools-cmm.823 update should
> > probably be reverted and/or moved to the inbox.
> Nope, it's fine. There's not much code there, maybe take a look
> before making such a suggestion? You didn't say anything when I
> pointed out the original hack doesn't work (and still doesn't), but
> for whatever reason, you want to revert my code, which does work. :(
I have not followed this dicussion closely, so I checked back to try
to make sense of it. I am still confused.
Eliot made a change (Tools-eem.817) to have debugger windows open with
a window size matching that of previously opened debugger windows. This
may or amy not be a hack but it seems to work as advertised.
Chris pointed out a problem, apparently caused by Tools-eem.817, that
affects his image:
I cannot say the cause of that problem, and I do not know how to reproduce
it, but it must be a problem otherwise Chris would not have raised the
Chris then introduced rememberExtent: in Tools-cmm.823, which apparently
is intended to provide a way to override Eliot's changes. But there
are no actual senders of rememberExtent: in the image.
Here is what I would say with confidence: A hack to work around
somebody else's hack does not belong in the trunk.
So I stand by my original statement that it would be good to revert
Tools-cmm.823 until the confusion can be sorted out.
Having said that, how can I actually reproduce the problem that Chris
reported earler in this post?
> > As a general observation, it is a good idea for all of us to make
> > use of the inbox for changes that may potentially conflict with
> > someone else's work in progress. Merging from inbox to trunk is
> > easy, so it is never a bad idea to use the inbox when we are looking
> > for feedback or review on our changes.
More information about the Squeak-dev