Hi Patrick,

Thanks for taking time to look at the failing tests. After updating the release candidate and installing your change sets now I have:
4513 run, 4459 passes, 43 expected failures, 8 failures, 3 errors, 0 unexpected passes

That is only 11 issues from green.

The three errors are SqueakSSLTest #testSSLSockets #testSocketAccept and testSocketConnect. Can other Mac testers confirm they see them, too?

Cheers,
Bernhard

> Am 12.10.2018 um 14:43 schrieb <patrick.rein at hpi.uni-potsdam.de> <patrick.rein at hpi.uni-potsdam.de>:
> 
> Just found an issue with one of the change sets myself. I updated one of the change sets but attached all three again in this mail.
> 
> Bests
> Patrick
> 
>> Hi everyone,
>> 
>> I looked into the test failures and fixed some of them and marked others as expected failures. I have attached the resulting changes as change sets as I am not yet sure whether we want to add them to trunk at this stage.
>> 
>> If someone could look into the changes and deems them save for late stage addition I am happy to merge them.
>> 
>> Bests
>> Patrick
>> 
>>> Hi Fabio,
>>> 
>>> Thanks to everyone working on the release! I really appreciate you continue to improve Squeak.
>>> 
>>> I downloaded the Squeak5.2rc1-18202-64bit-201810071412-macOS.dmg. I am on macOS Sierra 10.12.6.
>>> 
>>> I ran all the tests with 4513 run, 4452 passes, 35 expected failures, 23 failures, 3 errors, 0 unexpected passes.
>>> 
>>> The three errors are in SqueakSSLTest. One of them, testSSLSockets even opened a debugger. So I am not sure if all tests ran. Also I don't understand why a debugger opens. Normally they don't when running tests, only when clicking on an error.
>>> 
>>> Is there an easy way to copy the test results?
>>> 
>>> I would find it great if the release had green tests. Maybe some of the failures and errors are to be expected?
>>> 
>>> Regards
>>> Bernhard
>>> 
>>>> Am 08.10.2018 um 18:30 schrieb H. Hirzel <hannes.hirzel at gmail.com>:
>>>> 
>>>> Hello Fabio
>>>> 
>>>> Thank you for putting out a new Squeak 5.2 release.
>>>> 
>>>> However it seems to me like a rushing exercise to release next Saturday.
>>>> 
>>>> See upcoming mail
>>>> 
>>>> Regards
>>>> Hannes
>>>> 
>>>> On 10/8/18, Fabio Niephaus <lists at fniephaus.com> wrote:
>>>>> Hi all,
>>>>> 
>>>>> As pre-announced at [1], here is the first release candidate of Squeak 5.2:
>>>>> http://files.squeak.org/5.2rc1/Squeak5.2rc1-18202-32bit/
>>>>> http://files.squeak.org/5.2rc1/Squeak5.2rc1-18202-64bit/
>>>>> 
>>>>> Please try them out and report any problems here on the mailing list.
>>>>> The Squeak 5.2 final release is planned for next Saturday (13th Oct 2018).
>>>>> 
>>>>> Best,
>>>>> Fabio
>>>>> 
>>>>> [1] http://forum.world.st/Squeak-5-2-release-on-13th-Oct-td5086533.html
>>> 
>>> 
>> ["PackageDependencyChanges.1.cs"]
>> ["UTF8EdgeCaseTests.1.cs"]
>> ["UIThemesTest.1.cs"]
>> 
>> 
>> [PackageDependencyChanges.1.cs]
>> [UTF8EdgeCaseTests.1.cs]
>> [UIThemesTest.1.cs]
> ["PackageDependencyChanges.3.cs"]
> ["UTF8EdgeCaseTests.1.cs"]
> ["UIThemesTest.1.cs"]<PackageDependencyChanges.3.cs><UTF8EdgeCaseTests.1.cs><UIThemesTest.1.cs>